From: Luke Diamand <luke@diamand.org>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Chris Li <git@chrisli.org>
Subject: Re: [PATCH v2 0/6] git-p4 tests, filetypes, shell metacharacters
Date: Sat, 15 Oct 2011 21:00:12 +0100 [thread overview]
Message-ID: <4E99E64C.9@diamand.org> (raw)
In-Reply-To: <20111015155358.GA29436@arf.padd.com>
On 15/10/11 16:53, Pete Wyckoff wrote:
> This series of six patches has been reviewed on the mailing list
> and should be ready for inclusion.
>
> 1 - Clean up git-p4 tests, including Junio review comments
>
> 2..4 - Handle p4 filetypes better, including Chris's suggested
> utf16 fix
>
> 5 - Fix p4 keyword parsing
>
> 6 - From Luke: avoid using the shell, so filenames with metacharacters
> are not errantly expanded
I've just tried running the tests in parallel (master branch) and it
works a treat.
You've also tidied up my earlier test cases very nicely.
There doesn't seem to be any way to cope with multiple instances of the
same test running at the same time. If p4d could write its pid somewhere
then something better could be done, but it doesn't.
Ack.
Thanks
Luke
>
> Luke Diamand (1):
> git-p4: handle files with shell metacharacters
>
> Pete Wyckoff (5):
> git-p4 tests: refactor and cleanup
> git-p4: handle utf16 filetype properly
> git-p4: recognize all p4 filetypes
> git-p4: stop ignoring apple filetype
> git-p4: keyword flattening fixes
>
> contrib/fast-import/git-p4 | 287 +++++++++++++-------
> t/lib-git-p4.sh | 74 +++++
> t/t9800-git-p4.sh | 574 ++++++++++++++++++----------------------
> t/t9801-git-p4-branch.sh | 233 ++++++++++++++++
> t/t9802-git-p4-filetype.sh | 108 ++++++++
> t/t9803-git-shell-metachars.sh | 64 +++++
> 6 files changed, 918 insertions(+), 422 deletions(-)
> create mode 100644 t/lib-git-p4.sh
> create mode 100755 t/t9801-git-p4-branch.sh
> create mode 100755 t/t9802-git-p4-filetype.sh
> create mode 100755 t/t9803-git-shell-metachars.sh
prev parent reply other threads:[~2011-10-15 20:01 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-15 15:53 [PATCH v2 0/6] git-p4 tests, filetypes, shell metacharacters Pete Wyckoff
2011-10-15 15:55 ` [PATCH 1/6] git-p4 tests: refactor and cleanup Pete Wyckoff
2011-10-16 9:38 ` Stefano Lattarini
2011-10-16 9:54 ` Stefano Lattarini
2011-10-16 14:35 ` Pete Wyckoff
2011-10-15 15:56 ` [PATCH 2/6] git-p4: handle utf16 filetype properly Pete Wyckoff
2011-10-16 9:52 ` Stefano Lattarini
2011-10-16 14:38 ` Pete Wyckoff
2011-10-15 15:57 ` [PATCH 3/6] git-p4: recognize all p4 filetypes Pete Wyckoff
2011-10-15 15:59 ` [PATCH 4/6] git-p4: stop ignoring apple filetype Pete Wyckoff
2011-10-15 16:00 ` [PATCH 5/6] git-p4: keyword flattening fixes Pete Wyckoff
2011-10-15 16:02 ` [PATCH 6/6] git-p4: handle files with shell metacharacters Pete Wyckoff
2011-10-15 20:00 ` Luke Diamand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4E99E64C.9@diamand.org \
--to=luke@diamand.org \
--cc=git@chrisli.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).