From: Robin Rosenberg <robin.rosenberg@gmail.com>
To: Jeff King <peff@peff.net>
Cc: "Nguyễn Thái Ngọc Duy" <pclouds@gmail.com>,
git@vger.kernel.org, "Junio C Hamano" <gitster@pobox.com>,
"Ævar Arnfjörð" <avarab@gmail.com>
Subject: Re: [PATCH 00/22] Refactor to accept NUL in commit messages
Date: Sun, 23 Oct 2011 12:44:30 +0200 [thread overview]
Message-ID: <4EA3F00E.9040006@gmail.com> (raw)
In-Reply-To: <20111022190914.GA1785@sigill.intra.peff.net>
Jeff King skrev 2011-10-22 21.09:
> On Sat, Oct 22, 2011 at 09:04:19PM +1100, Nguyen Thai Ngoc Duy wrote:
>
>> This series helps pass commit message size up to output functions,
>> though it does not change any output functions to print ^@.
> Can we take a step back for a second and discuss what git _should_ do
> with commits that contain NUL?
Yes please. I don't think allowing NUL makes sense, but it makes sense
to state how NUL should be handled when anyone attempt it, so there
might be things to fix even if NUL is banned.
Are there any such commits in the wild?
-- robin
next prev parent reply other threads:[~2011-10-23 10:44 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1319277881-4128-1-git-send-email-pclouds@gmail.com>
2011-10-22 19:09 ` [PATCH 00/22] Refactor to accept NUL in commit messages Jeff King
2011-10-23 10:44 ` Robin Rosenberg [this message]
2011-10-23 16:09 ` Jeff King
2011-10-22 22:47 ` Junio C Hamano
2011-10-23 1:24 ` Nguyen Thai Ngoc Duy
2011-10-23 5:51 ` Junio C Hamano
2011-10-23 6:37 ` Nguyen Thai Ngoc Duy
2011-10-23 9:46 ` Junio C Hamano
2011-10-23 10:17 ` Nguyen Thai Ngoc Duy
2011-10-23 16:07 ` Jeff King
2011-10-23 20:16 ` Junio C Hamano
2011-10-24 4:40 ` Junio C Hamano
2011-10-24 5:10 ` Nguyen Thai Ngoc Duy
2011-10-24 11:09 ` Štěpán Němec
2011-10-24 22:45 ` Jeff King
2011-10-25 10:16 ` Štěpán Němec
2011-10-25 14:07 ` Junio C Hamano
2011-10-27 18:13 ` Jeff King
2011-10-27 18:47 ` Junio C Hamano
2011-10-27 18:52 ` Jeff King
2011-10-27 19:14 ` Junio C Hamano
2011-10-27 23:44 ` Jeff King
2011-10-28 0:03 ` Junio C Hamano
2011-10-28 0:19 ` Jeff King
2011-10-28 1:40 ` Miles Bader
2011-10-28 4:07 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EA3F00E.9040006@gmail.com \
--to=robin.rosenberg@gmail.com \
--cc=avarab@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=pclouds@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).