* [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
@ 2011-10-25 17:15 Ramsay Jones
2011-10-25 22:58 ` Drew Northup
0 siblings, 1 reply; 6+ messages in thread
From: Ramsay Jones @ 2011-10-25 17:15 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jakub Narebski, GIT Mailing-list
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
---
gitweb/Makefile | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 1c85b5f..4191c6b 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -185,7 +185,9 @@ install: all
### Cleaning rules
clean:
- $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+ $(RM) gitweb.cgi static/gitweb.js \
+ static/gitweb.min.js static/gitweb.min.css \
+ GITWEB-BUILD-OPTIONS
.PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
--
1.7.7
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
2011-10-25 17:15 [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Ramsay Jones
@ 2011-10-25 22:58 ` Drew Northup
2011-10-26 0:36 ` Jakub Narebski
0 siblings, 1 reply; 6+ messages in thread
From: Drew Northup @ 2011-10-25 22:58 UTC (permalink / raw)
To: Ramsay Jones; +Cc: Junio C Hamano, Jakub Narebski, GIT Mailing-list
On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> ---
> gitweb/Makefile | 4 +++-
> 1 files changed, 3 insertions(+), 1 deletions(-)
>
> diff --git a/gitweb/Makefile b/gitweb/Makefile
> index 1c85b5f..4191c6b 100644
> --- a/gitweb/Makefile
> +++ b/gitweb/Makefile
> @@ -185,7 +185,9 @@ install: all
> ### Cleaning rules
>
> clean:
> - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
> + $(RM) gitweb.cgi static/gitweb.js \
> + static/gitweb.min.js static/gitweb.min.css \
> + GITWEB-BUILD-OPTIONS
>
> .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
>
Forgive me for sounding a bit numb, but what does this fix? I don't see
it in the commit message.
--
-Drew Northup
________________________________________________
"As opposed to vegetable or mineral error?"
-John Pescatore, SANS NewsBites Vol. 12 Num. 59
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
2011-10-25 22:58 ` Drew Northup
@ 2011-10-26 0:36 ` Jakub Narebski
2011-10-26 21:30 ` Ramsay Jones
0 siblings, 1 reply; 6+ messages in thread
From: Jakub Narebski @ 2011-10-26 0:36 UTC (permalink / raw)
To: Drew Northup; +Cc: Ramsay Jones, Junio C Hamano, GIT Mailing-list
Drew Northup napisał:
> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
> > Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
> > ---
> > gitweb/Makefile | 4 +++-
> > 1 files changed, 3 insertions(+), 1 deletions(-)
> >
> > diff --git a/gitweb/Makefile b/gitweb/Makefile
> > index 1c85b5f..4191c6b 100644
> > --- a/gitweb/Makefile
> > +++ b/gitweb/Makefile
> > @@ -185,7 +185,9 @@ install: all
> > ### Cleaning rules
> >
> > clean:
> > - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
> > + $(RM) gitweb.cgi static/gitweb.js \
> > + static/gitweb.min.js static/gitweb.min.css \
> > + GITWEB-BUILD-OPTIONS
> >
> > .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
> >
>
> Forgive me for sounding a bit numb, but what does this fix? I don't see
> it in the commit message.
gitweb.js is nowadays a generated file. Though that bit should be
in commit message...
--
Jakub Narebski
Poland
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
2011-10-26 0:36 ` Jakub Narebski
@ 2011-10-26 21:30 ` Ramsay Jones
2011-10-27 17:49 ` Junio C Hamano
0 siblings, 1 reply; 6+ messages in thread
From: Ramsay Jones @ 2011-10-26 21:30 UTC (permalink / raw)
To: Jakub Narebski; +Cc: Drew Northup, Junio C Hamano, GIT Mailing-list
Jakub Narebski wrote:
> Drew Northup napisał:
>> On Tue, 2011-10-25 at 18:15 +0100, Ramsay Jones wrote:
>>> Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
>>> ---
>>> gitweb/Makefile | 4 +++-
>>> 1 files changed, 3 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/gitweb/Makefile b/gitweb/Makefile
>>> index 1c85b5f..4191c6b 100644
>>> --- a/gitweb/Makefile
>>> +++ b/gitweb/Makefile
>>> @@ -185,7 +185,9 @@ install: all
>>> ### Cleaning rules
>>>
>>> clean:
>>> - $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
>>> + $(RM) gitweb.cgi static/gitweb.js \
>>> + static/gitweb.min.js static/gitweb.min.css \
>>> + GITWEB-BUILD-OPTIONS
>>>
>>> .PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
>>>
>> Forgive me for sounding a bit numb, but what does this fix? I don't see
>> it in the commit message.
>
> gitweb.js is nowadays a generated file. Though that bit should be
> in commit message...
Yep, will do ...
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
2011-10-26 21:30 ` Ramsay Jones
@ 2011-10-27 17:49 ` Junio C Hamano
2011-10-29 19:59 ` Ramsay Jones
0 siblings, 1 reply; 6+ messages in thread
From: Junio C Hamano @ 2011-10-27 17:49 UTC (permalink / raw)
To: Ramsay Jones
Cc: Jakub Narebski, Drew Northup, Junio C Hamano, GIT Mailing-list
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>> gitweb.js is nowadays a generated file. Though that bit should be
>> in commit message...
>
> Yep, will do ...
Thanks; here is what I already queued.
-- >8 --
From: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Date: Tue, 25 Oct 2011 18:15:20 +0100
Subject: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
Since 9a86dd5 (gitweb: Split JavaScript for maintability, combining on
build, 2011-04-28), static/gitweb.js has been a build product that should
be cleaned upon "make clean".
Signed-off-by: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
---
gitweb/Makefile | 4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/gitweb/Makefile b/gitweb/Makefile
index 5d20515..c360284 100644
--- a/gitweb/Makefile
+++ b/gitweb/Makefile
@@ -183,7 +183,9 @@ install: all
### Cleaning rules
clean:
- $(RM) gitweb.cgi static/gitweb.min.js static/gitweb.min.css GITWEB-BUILD-OPTIONS
+ $(RM) gitweb.cgi static/gitweb.js \
+ static/gitweb.min.js static/gitweb.min.css \
+ GITWEB-BUILD-OPTIONS
.PHONY: all clean install test test-installed .FORCE-GIT-VERSION-FILE FORCE
--
1.7.7.1.552.g2c3d8
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target
2011-10-27 17:49 ` Junio C Hamano
@ 2011-10-29 19:59 ` Ramsay Jones
0 siblings, 0 replies; 6+ messages in thread
From: Ramsay Jones @ 2011-10-29 19:59 UTC (permalink / raw)
To: Junio C Hamano; +Cc: Jakub Narebski, Drew Northup, GIT Mailing-list
Junio C Hamano wrote:
> Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
>
>>> gitweb.js is nowadays a generated file. Though that bit should be
>>> in commit message...
>> Yep, will do ...
>
> Thanks; here is what I already queued.
Yeah, I saw this about two hours after I sent those emails ...
Also, I prefer your commit message! ;-)
Thanks.
ATB,
Ramsay Jones
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2011-10-30 18:27 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-10-25 17:15 [PATCH] gitweb/Makefile: Remove static/gitweb.js in the clean target Ramsay Jones
2011-10-25 22:58 ` Drew Northup
2011-10-26 0:36 ` Jakub Narebski
2011-10-26 21:30 ` Ramsay Jones
2011-10-27 17:49 ` Junio C Hamano
2011-10-29 19:59 ` Ramsay Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).