From: Michael Lutz <michi@icosahedron.de>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-svn: add hook to allow modifying the subversion commit message
Date: Tue, 01 Nov 2011 21:45:43 +0100 [thread overview]
Message-ID: <4EB05A77.4050901@icosahedron.de> (raw)
In-Reply-To: <20111101202806.GB29769@dcvr.yhbt.net>
Am 01.11.2011 21:28 schrieb Eric Wong:
> I'm not convinced this is a good feature to support. We already have
> --no-metadata to remove git-svn-id: lines and I hate that feature
> because it introduced extra variables for testing/debugging/recovery.
>
> Metadata in the commit message is important, if you want to remove
> it after-the-fact, there's git-filter-branch.
The actual use case here is to replace a custom hack that adds some info
to the git commit message. In this case filter-branch isn't an option
because git-svn continuously pulls from the subversion master repository.
Additionally, especially for *adding* information, the information might
not be available later any more.
The only current metadata (the git-svn-id line) isn't affected by this
change as git-svn outputs it separately after the svn commit message that
the proposed hook can modify.
I fully realize that this is a rather specialized feature but I wanted to
publish it in case somebody else finds a use for this as well.
Michael Lutz
prev parent reply other threads:[~2011-11-01 20:45 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-10-21 20:25 [PATCH] git-svn: add hook to allow modifying the subversion commit message Michael Lutz
2011-11-01 20:28 ` Eric Wong
2011-11-01 20:45 ` Michael Lutz [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EB05A77.4050901@icosahedron.de \
--to=michi@icosahedron.de \
--cc=git@vger.kernel.org \
--cc=normalperson@yhbt.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).