git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Schuberth <sschuberth@gmail.com>
To: Pat Thoyts <patthoyts@gmail.com>
Cc: Vincent van Ravesteijn <vfr@lyx.org>,
	Johannes Schindelin <Johannes.Schindelin@gmx.de>,
	ramsay@ramsay1.demon.co.uk, msysgit@googlegroups.com,
	Karsten Blees <blees@dcon.de>,
	git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
	Erik Faye-Lund <kusmabite@gmail.com>
Subject: Re: [msysGit] Re: [PATCHv2] Compile fix for MSVC
Date: Fri, 04 Nov 2011 16:39:43 +0100	[thread overview]
Message-ID: <4EB4073F.6070100@gmail.com> (raw)
In-Reply-To: <CABNJ2G+Km4wob4_uNYQLkQUL61-ohZg5cL2yu7j1cngoL9W7Cw@mail.gmail.com>

On 02.11.2011 01:48, Pat Thoyts wrote:

>> As long as this means to just run a not so complicated perl script, this
>> Could even be done in a commit hook.
>>
>> Just another question. How does the (msys)git community feel about adding
>> CMake support ? I can probably do that quite easily.
>
> -1. We have a make. We don't need two of them.

I don't see CMake as an alternative to make as CMake would be used to 
generate the Makefile, which is currently hard-coded and committed.

However, I don't see any benefit in using CMake as long as the Linux 
guys don't use it to create their Makefile, too.

-- 
Sebastian Schuberth

  parent reply	other threads:[~2011-11-04 15:41 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-10-31 19:12 [PATCHv2] Compile fix for MSVC Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 1/3] Compile fix for MSVC: Do not include sys/resources.h Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 2/3] Compile fix for MSVC: Include <io.h> Vincent van Ravesteijn
2011-10-31 19:12 ` [PATCH 3/3] MSVC: Remove unneeded header stubs Vincent van Ravesteijn
2011-10-31 20:34 ` [PATCHv2] Compile fix for MSVC Junio C Hamano
2011-11-01  0:09   ` [msysGit] " Johannes Schindelin
2011-11-01  3:30     ` Junio C Hamano
2011-11-01 11:56     ` Erik Faye-Lund
2011-11-01 16:45       ` Junio C Hamano
2011-11-01 20:35         ` Erik Faye-Lund
2011-11-01 20:47           ` Junio C Hamano
2011-11-01 18:40       ` Johannes Schindelin
2011-11-01 20:43         ` Erik Faye-Lund
2011-11-01 22:51           ` [msysGit] " Johannes Schindelin
2011-11-01 22:32         ` Vincent van Ravesteijn
2011-11-01 22:40           ` [msysGit] " Johannes Schindelin
2011-11-01 23:33             ` Vincent van Ravesteijn
2011-11-02  0:48           ` [msysGit] " Pat Thoyts
2011-11-02  7:34             ` Vincent van Ravesteijn
2011-11-04 15:39             ` Sebastian Schuberth [this message]
2011-11-01  0:36   ` Erik Faye-Lund
2011-11-01  3:30     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EB4073F.6070100@gmail.com \
    --to=sschuberth@gmail.com \
    --cc=Johannes.Schindelin@gmx.de \
    --cc=blees@dcon.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=kusmabite@gmail.com \
    --cc=msysgit@googlegroups.com \
    --cc=patthoyts@gmail.com \
    --cc=ramsay@ramsay1.demon.co.uk \
    --cc=vfr@lyx.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).