From: Eric Raible <raible@nextest.com>
To: Jeff King <peff@peff.net>
Cc: "git@vger.kernel.org" <git@vger.kernel.org>
Subject: Re: RFH: unexpected reflog behavior with --since=
Date: Thu, 10 Nov 2011 00:20:19 -0800 [thread overview]
Message-ID: <4EBB8943.4060801@nextest.com> (raw)
In-Reply-To: <20111110080851.GA28342@sigill.intra.peff.net>
On 11/10/2011 12:08 AM, Jeff King wrote:
>>> git log -g --format='%ct %H' |
>>> awk '{ print $2 if $1 < SOME_TIMESTAMP }'
>>
>> And then the sha would have to be fed back into git to be useful, eh?
>
> It's just illustrative. You could replace "%H" with the actual
> information you're interested in.
Of course, my thinko.
> The only point would be to leave "--since" to act on the commit
> timestamps, so that you don't have to resort to the external grepping I
> mentioned above. However, I'm not convinced anybody even cares about
> that use case.
>
> I think the behavior you want is much more sensible.
Me too!
>> Is this something you'd be willing to turn into a real patch?
>> I'm certainly not qualified.
>
> Yes. We're in release freeze now, so I didn't even bother with sending
> it to Junio. But also, I'd like to gather more opinions on whether the
> design is the right thing (hopefully the implementation is Obviously
> Correct. :) ).
I think it's hard to argue that the current behavior (as illustrated with
my original example) makes sense. Or that your patch is overly complicated.
But giving people time to chime in it definitely TRTTD.
- Eric
next prev parent reply other threads:[~2011-11-10 8:20 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-09 0:22 RFH: unexpected reflog behavior with --since= Eric Raible
2011-11-09 22:01 ` Jeff King
2011-11-09 22:20 ` Jeff King
2011-11-09 22:26 ` Jeff King
2011-11-10 8:04 ` Eric Raible
2011-11-10 8:08 ` Jeff King
2011-11-10 8:20 ` Eric Raible [this message]
2011-11-10 8:31 ` Jay Soffian
2011-11-10 11:06 ` Miles Bader
2011-11-10 18:18 ` Eric Raible
2011-11-12 6:50 ` Junio C Hamano
2011-11-10 7:48 ` Eric Raible
2011-11-10 7:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EBB8943.4060801@nextest.com \
--to=raible@nextest.com \
--cc=git@vger.kernel.org \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).