From: Vincent van Ravesteijn <vfr@lyx.org>
To: kusmabite@gmail.com
Cc: git@vger.kernel.org, gitster@pobox.com, msysgit@googlegroups.com,
j.sixt@viscovery.net
Subject: Re: [PATCH] Compile fix for MSVC: Move poll.h out of sys-folder
Date: Fri, 18 Nov 2011 15:42:07 +0100 [thread overview]
Message-ID: <4EC66EBF.20007@lyx.org> (raw)
In-Reply-To: <CABPQNSa+ZjAMSxpBTqGW7P=v-tJTW_jdx3MO=vCpzc-z_XdHTg@mail.gmail.com>
> This looks strange to me. vcbuild/include/poll.h will only prevent the
> correct header from being included, while compiling an linking against
> compat/win32/poll.[co]... That seems dangerous to me, because the
> interface might be declared differently.
>
> Instead, I think compat/vcbuild/include/poll.h should be removed,
Yes, it should just be removed. Having poll.h in the sys directory was
wrong and the patch I sent was needed to make 0f77dea compile.
Your patch is indeed necessary to compile later revisions as well.
> I still can't build Junio's master,
> due to sys/resource.h missing. This comes from ebae9ff ("compat: add
> missing #include<sys/resource.h>"), and is only guarded against
> MinGW, not MSVC...
The fix for this is already in 'next' now. So, with your patch, 'next'
does compile.
Vincent
prev parent reply other threads:[~2011-11-18 14:42 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-18 13:47 [PATCH] Compile fix for MSVC: Move poll.h out of sys-folder Vincent van Ravesteijn
2011-11-18 14:09 ` Erik Faye-Lund
2011-11-18 14:28 ` Erik Faye-Lund
2011-11-18 16:47 ` Vincent van Ravesteijn
2011-11-18 14:42 ` Vincent van Ravesteijn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EC66EBF.20007@lyx.org \
--to=vfr@lyx.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=j.sixt@viscovery.net \
--cc=kusmabite@gmail.com \
--cc=msysgit@googlegroups.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).