From: Vincent van Ravesteijn <vfr@lyx.org>
To: Philippe Vaucher <philippe.vaucher@gmail.com>
Cc: git@vger.kernel.org
Subject: Re: git reset --merge documentation improvments
Date: Wed, 23 Nov 2011 09:57:09 +0100 [thread overview]
Message-ID: <4ECCB565.9020706@lyx.org> (raw)
In-Reply-To: <CAGK7Mr59bN8rjhLHAK0Vq=bOBBHG=N02CgGe-np=OBdTyS+rsA@mail.gmail.com>
Op 23-11-2011 9:31, Philippe Vaucher schreef:
> Hello,
>
> The current documentation for --merge is:
>
> "Resets the index [1] and updates the files in the working tree that
> are different between<commit> and HEAD, but keeps those which are
> different between the index [2] and working tree"
>
> I think this is confusing, because [1] is the *after-reset* index and
> [2] is the *before-reset* index.
You mean that you read that the *after-reset* index is reset ? They both
refer to the *before-reset* index.
> If you fail to realise this it looks
> like this "resets index (so index is empty) and then updates worktree
> but skip files staged from index" --> "but there's nothing staged, the
> index was reset!"
The misunderstanding comes from the added "then".
>
> I think a better sentence would be:
>
> "Updates the files in the working tree that are different between
> <commit> and HEAD, but keeps those which are different between the
> index and working tree, and finally resets the index."
There is nothing to update as long as the index is not reset.
Vincent
next prev parent reply other threads:[~2011-11-23 8:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-23 8:31 git reset --merge documentation improvments Philippe Vaucher
2011-11-23 8:57 ` Vincent van Ravesteijn [this message]
2011-11-23 11:39 ` Philippe Vaucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ECCB565.9020706@lyx.org \
--to=vfr@lyx.org \
--cc=git@vger.kernel.org \
--cc=philippe.vaucher@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).