From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Jeff King <peff@peff.net>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 11/13] strbuf: add strbuf_add*_urlencode
Date: Wed, 30 Nov 2011 06:41:37 +0100 [thread overview]
Message-ID: <4ED5C211.6040401@lsrfire.ath.cx> (raw)
In-Reply-To: <20111130032028.GA24704@sigill.intra.peff.net>
Am 30.11.2011 04:20, schrieb Jeff King:
> On Wed, Nov 30, 2011 at 12:26:20AM +0100, René Scharfe wrote:
>
>>>>> +static int is_rfc3986_reserved(char ch)
>>>>> +{
>>>>> + switch (ch) {
>>>>> + case '!': case '*': case '\'': case '(': case ')': case ';':
>>>>> + case ':': case '@': case '&': case '=': case '+': case '$':
>>>>> + case ',': case '/': case '?': case '#': case '[': case ']':
>>>>> + return 1;
>>>>> + }
>> [...]
>> Sorry for my bikeshedding, but I'd paint it like this:
>>
>> return !!strchr("!*'();:@&=+$,/?#[]", ch);
>
> I was always under the impression that computed jumps via "switch" would
> out-perform even an optimized strchr. Of course, I never tested. And I
> doubt performance is even relevant here, and I admit I don't care overly
> much. I find them both equally readable.
>
> I'm going to leave it as-is unless somebody else wants to say "I
> strongly prefer version X".
Sure, the second one is significantly slower than the first one. I just
prefer it based one its looks in case performance doesn't matter, but
that's probably just me being (sometimes too) fond of terseness. :)
René
next prev parent reply other threads:[~2011-11-30 5:41 UTC|newest]
Thread overview: 49+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-24 10:58 [PATCH 0/13] credential helpers, take two Jeff King
2011-11-24 10:58 ` [PATCH 01/13] test-lib: add test_config_global variant Jeff King
2011-11-24 10:59 ` [PATCH 02/13] t5550: fix typo Jeff King
2011-11-24 11:01 ` [PATCH 03/13] introduce credentials API Jeff King
2011-11-28 21:46 ` Junio C Hamano
2011-11-29 5:04 ` Jeff King
2011-11-29 17:34 ` Junio C Hamano
2011-11-29 21:14 ` Jeff King
2011-11-24 11:01 ` [PATCH 04/13] credential: add function for parsing url components Jeff King
2011-11-24 11:01 ` [PATCH 05/13] http: use credential API to get passwords Jeff King
2011-11-24 11:02 ` [PATCH 06/13] credential: apply helper config Jeff King
2011-11-24 11:02 ` [PATCH 07/13] credential: add credential.*.username Jeff King
2011-11-24 11:03 ` [PATCH 08/13] credential: make relevance of http path configurable Jeff King
2011-11-24 11:05 ` [PATCH 09/13] docs: end-user documentation for the credential subsystem Jeff King
2011-11-24 11:07 ` [PATCH 10/13] credentials: add "cache" helper Jeff King
2011-11-24 14:36 ` Eric Sunshine
2011-11-29 0:42 ` Junio C Hamano
2011-11-29 5:04 ` Jeff King
2011-11-24 11:07 ` [PATCH 11/13] strbuf: add strbuf_add*_urlencode Jeff King
2011-11-29 18:19 ` Junio C Hamano
2011-11-29 21:19 ` Jeff King
2011-11-29 23:26 ` René Scharfe
2011-11-30 3:20 ` Jeff King
2011-11-30 5:40 ` Junio C Hamano
2011-11-30 5:41 ` René Scharfe [this message]
2011-11-24 11:07 ` [PATCH 12/13] credentials: add "store" helper Jeff King
2011-11-24 14:29 ` Eric Sunshine
2011-11-24 20:09 ` Jeff King
2011-11-29 18:19 ` Junio C Hamano
2011-11-29 21:38 ` Jeff King
2011-11-24 11:09 ` [PATCH 13/13] t: add test harness for external credential helpers Jeff King
2011-11-24 11:45 ` [PATCH 0/13] credential helpers, take two Erik Faye-Lund
2011-11-24 11:53 ` Jeff King
2011-11-24 12:08 ` Erik Faye-Lund
2011-11-27 8:27 ` [PATCH 0/6] echo usernames as they are typed Jeff King
2011-11-27 8:28 ` [PATCH 1/6] move git_getpass to its own source file Jeff King
2011-11-27 8:29 ` [PATCH 2/6] refactor git_getpass into generic prompt function Jeff King
2011-11-27 8:30 ` [PATCH 3/6] stub out getpass_echo function Jeff King
2011-11-27 8:30 ` [PATCH 4/6] prompt: add PROMPT_ECHO flag Jeff King
2011-11-27 8:31 ` [PATCH 5/6] credential: use git_prompt instead of git_getpass Jeff King
2011-11-27 8:31 ` [PATCH 6/6] compat/getpass: add a /dev/tty implementation Jeff King
2011-11-27 8:56 ` [PATCH 0/6] echo usernames as they are typed Junio C Hamano
2011-11-27 9:17 ` Erik Faye-Lund
2011-11-28 3:53 ` Jeff King
2011-11-28 9:36 ` Erik Faye-Lund
2011-11-28 11:31 ` Jeff King
2011-11-28 11:49 ` Frans Klaver
2011-11-28 12:59 ` Erik Faye-Lund
2011-11-28 18:59 ` Jeff King
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED5C211.6040401@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).