From: Luke Diamand <luke@diamand.org>
To: Vitor Antunes <vitor.hda@gmail.com>
Cc: Pete Wyckoff <pw@padd.com>, git@vger.kernel.org
Subject: Re: [PATCHv2 0/4] git-p4: small fixes to branches and labels; tests
Date: Fri, 02 Dec 2011 08:49:25 +0000 [thread overview]
Message-ID: <4ED89115.6040309@diamand.org> (raw)
In-Reply-To: <CAOpHH-XL5OGpnihEgqnXqUUFsMxXn2wSdLadegnC1epg44vs8A@mail.gmail.com>
On 01/12/11 21:59, Vitor Antunes wrote:
> On Dec 1, 2011 4:03 AM, "Pete Wyckoff"<pw@padd.com> wrote:
>> I see your point. P4 labels are the only way that they support
>> tagging, apparently. I'm okay with leaving label support in
>> git-p4. And it will be nice if Luke makes it behave a bit
>> better. But doing heroics to emulate cross-commit tags feels
>> like a lot of work, and the wrong direction.
>
> Agreed. Lets keep it simple.
>
I think I'm going to have to go away and do a bit more work on this. The
existing label code is still quite buggy (or my understanding is
broken). Either way I'd rather get it to the point where it actually
works and passes all its tests.
The two issues I'm seeing are:
- two p4 labels covering the same set of files; only one of them gets
imported.
- if you have a p4 label on a subset of files then it gets dropped
(which is fine) but so do most of the other labels (as far as I can tell).
I think if this could be made to work it would actually be really useful
though.
(Pete - I've found your previous email; not sure why I didn't see it
before. I'll roll that change in with what I'm doing).
Regards!
Luke
prev parent reply other threads:[~2011-12-02 8:49 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-11-30 9:03 [PATCHv2 0/4] git-p4: small fixes to branches and labels; tests Luke Diamand
2011-11-30 9:03 ` [PATCHv2 1/4] git-p4: handle p4 branches and labels containing shell chars Luke Diamand
2011-11-30 9:03 ` [PATCHv2 2/4] git-p4: cope with labels with empty descriptions Luke Diamand
2011-11-30 9:03 ` [PATCHv2 3/4] git-p4: importing labels should cope with missing owner Luke Diamand
2011-11-30 9:03 ` [PATCHv2 4/4] git-p4: add test for p4 labels Luke Diamand
2011-11-30 14:55 ` [PATCHv2 0/4] git-p4: small fixes to branches and labels; tests Vitor Antunes
2011-11-30 19:14 ` Luke Diamand
2011-11-30 19:44 ` Vitor Antunes
2011-11-30 22:58 ` Pete Wyckoff
2011-11-30 23:00 ` Pete Wyckoff
2011-12-01 0:37 ` Vitor Antunes
2011-12-04 16:07 ` Pete Wyckoff
2011-12-01 8:31 ` Luke Diamand
2011-12-01 0:33 ` Vitor Antunes
2011-12-01 4:02 ` Pete Wyckoff
[not found] ` <CAOpHH-UMdLpCPx1+D2dtQJs+=t1+0U2srKfTwBi-TEF4F7EDyw@mail.gmail.com>
2011-12-01 21:59 ` Vitor Antunes
2011-12-02 8:49 ` Luke Diamand [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4ED89115.6040309@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
--cc=vitor.hda@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).