From: Luke Diamand <luke@diamand.org>
To: Pete Wyckoff <pw@padd.com>
Cc: git@vger.kernel.org
Subject: Re: [RFC PATCH] git-p4: introduce asciidoc documentation
Date: Wed, 07 Dec 2011 09:46:57 +0000 [thread overview]
Message-ID: <4EDF3611.3000902@diamand.org> (raw)
In-Reply-To: <20111203235328.GA3866@arf.padd.com>
On 03/12/11 23:53, Pete Wyckoff wrote:
> Add proper documentation for git-p4. Delete the old .txt
> documentation from contrib/fast-import.
> ---
>
> I'd appreciate review by git-p4 people to make sure I captured
> everything from the old documentation, and to catch any errors.
> There's a fair amount of new content in here, describing all
> the options and variables. I left out some obscure commands
> on purpose.
>
> Comments from anyone else would be welcome too. Especially
> in the area of generic asciidoc formatting or style in git
> command pages.
That looks good to me, I can't see anything of note, just one minor nit,
below.
Luke
>
> Thanks,
> -- Pete
>
> Documentation/git-p4.txt | 456 ++++++++++++++++++++++++++++++++++++++++
> contrib/fast-import/git-p4.txt | 289 -------------------------
> 2 files changed, 456 insertions(+), 289 deletions(-)
> create mode 100644 Documentation/git-p4.txt
> delete mode 100644 contrib/fast-import/git-p4.txt
> +
>
> +------------
> +$ cd project
> +$ vi foo.h
I think it works with other editors as well, although I've not tried it
myself. Obviously with reduced functionality :-)
> +git-p4.allowSubmit::
> + By default, any branch can be used as the source for a 'git p4
> + submit' operation. This configuration variable , if set, permits only
Spacing around comma in "variable , if set"
Luke
next prev parent reply other threads:[~2011-12-07 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-03 23:53 [RFC PATCH] git-p4: introduce asciidoc documentation Pete Wyckoff
2011-12-04 21:33 ` Frans Klaver
2011-12-04 21:49 ` Pete Wyckoff
2011-12-07 9:46 ` Luke Diamand [this message]
2011-12-07 15:36 ` Pete Wyckoff
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EDF3611.3000902@diamand.org \
--to=luke@diamand.org \
--cc=git@vger.kernel.org \
--cc=pw@padd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).