git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Phil Hord <phil.hord@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
	Heiko Voigt <hvoigt@hvoigt.net>,
	Fredrik Gustafsson <iveqy@iveqy.com>,
	git@vger.kernel.org
Subject: Re: [PATCH v4 2/2] push: teach --recurse-submodules the on-demand option
Date: Tue, 13 Dec 2011 09:48:27 +0100	[thread overview]
Message-ID: <4EE7115B.8040000@web.de> (raw)
In-Reply-To: <CABURp0qkKXCW-U=78OpnejdtdpphhJtOoDubz77m7Gt3o5sC=Q@mail.gmail.com>

Am 13.12.2011 00:50, schrieb Phil Hord:
> On Mon, Dec 12, 2011 at 5:29 PM, Jens Lehmann <Jens.Lehmann@web.de> wrote:
>> Am 12.12.2011 22:16, schrieb Phil Hord:
>>>  I thought-experimented with this a bit last year and came to the
>>> conclusion that I should be able to 'float' to tips (developer
>>> convenience) and also to store the SHA-1 of each gitlink through
>>> history (automated maybe; as-needed).
>>
>> Which means that after "git submodule update" floated a submodule branch
>> further, you would have to commit that in the superproject.
> 
> Sadly, yes.  Currently I have my CI-server do this for me after it
> verifies each new submodule commit is able to build successfully.

Which I think is a good thing to do, as you have a good chance of
catching breakage introduced by the submodule updates. "float-only"
submodules won't always be a pleasant experience, as they can (and
sometimes will) get you into trouble when advancing them introduces
bugs (and then you can't even bisect that breakage).

>>> The problem with "float + gitlinks", of course, is that it looks like
>>> "not floating" to the developers (git-status is dirty unless
>>> overridden, etc.)
>>
>> Yeah. But what if each "git submodule update" would update the tip of
>> the submodule branch and add that to the superproject? You could follow
>> a tip but still produce reproducible trees.
> 
> Yes, and that's what I want.
> 
> Not what it sounded like was being suggested before, which (to my
> eyes) implied that the submodule gitlinks were useless noise.

It was suggested in other threads in the past. For a start, you could
write a script doing that and play around with it. And if that works
well for you, we can discuss if implementing that functionality into
"git submodule update" makes sense.

      reply	other threads:[~2011-12-13  8:48 UTC|newest]

Thread overview: 20+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-08-19 22:08 [PATCH v4 0/2] push: submodule support Fredrik Gustafsson
2011-08-19 22:08 ` [PATCH v4 1/2] push: Don't push a repository with unpushed submodules Fredrik Gustafsson
2011-08-19 23:26   ` Junio C Hamano
2011-08-20  6:32     ` Junio C Hamano
2011-08-21  6:48       ` Junio C Hamano
2011-08-22 19:47         ` Heiko Voigt
2011-08-22 22:22           ` Junio C Hamano
2011-08-23 19:45             ` Heiko Voigt
2011-08-24 21:14             ` [WIP PATCH] revision-walking: allow iterating revisions multiple times Heiko Voigt
2011-08-24 21:44               ` Junio C Hamano
2011-08-20  6:34     ` [PATCH 2/2] demonstrate format-callback used in combined diff Junio C Hamano
2011-08-21 21:55       ` Fredrik Gustafsson
2011-08-19 22:08 ` [PATCH v4 2/2] push: teach --recurse-submodules the on-demand option Fredrik Gustafsson
2011-09-02 18:21   ` Junio C Hamano
     [not found]     ` <20111017190749.GA3126@sandbox-rc>
2011-10-17 22:33       ` Junio C Hamano
2011-10-18 20:58         ` Jens Lehmann
2011-12-12 21:16           ` Phil Hord
2011-12-12 22:29             ` Jens Lehmann
2011-12-12 23:50               ` Phil Hord
2011-12-13  8:48                 ` Jens Lehmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EE7115B.8040000@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=hvoigt@hvoigt.net \
    --cc=iveqy@iveqy.com \
    --cc=phil.hord@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).