From: Johannes Sixt <j.sixt@viscovery.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Joe Ratterman <jratt0@gmail.com>, git@vger.kernel.org
Subject: Re: [PATCH] Add '-P' as a synonym for '--no-pager' in the git command
Date: Wed, 14 Dec 2011 08:44:00 +0100 [thread overview]
Message-ID: <4EE853C0.20505@viscovery.net> (raw)
In-Reply-To: <1323815706-10560-2-git-send-email-jratt0@gmail.com>
Am 12/13/2011 23:35, schrieb Joe Ratterman:
> +test_expect_success TTY 'no pager with -P' '
> + rm -f paginated.out ||
> + cleanup_fail &&
> +
> + test_terminal git -P log &&
> + ! test -e paginated.out
> +'
> +
> test_expect_success TTY 'no pager with --no-pager' '
> rm -f paginated.out ||
> cleanup_fail &&
What kind of bogosity do I see in the context of this hunk (and in the new
text as well, but it is not entirely your fault, Joe, since you obviously
have only copied an existing test snippet)?
Wouldn't rm -f always succeed under normal circumstances, and then the
rest of the test would be skipped? This use of || was introduced by
fdf1bc48 (t7006: guard cleanup with test_expect_success).
-- Hannes
next prev parent reply other threads:[~2011-12-14 7:44 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 22:35 [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD Joe Ratterman
2011-12-13 22:35 ` [PATCH] Add '-P' as a synonym for '--no-pager' in the git command Joe Ratterman
2011-12-14 7:44 ` Johannes Sixt [this message]
2011-12-14 8:22 ` [PATCH] test: errors preparing for a test are not special Jonathan Nieder
2011-12-14 8:51 ` Johannes Sixt
2011-12-14 9:00 ` Jonathan Nieder
2011-12-14 8:53 ` [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD Jonathan Nieder
-- strict thread matches above, loose matches on Subject: below --
2011-12-15 20:55 [PATCH] Add '-P' as a synonym for '--no-pager' in the git command Joe Ratterman
2011-12-15 21:41 ` Junio C Hamano
2011-12-16 9:30 ` Matthieu Moy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE853C0.20505@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=jratt0@gmail.com \
--cc=jrnieder@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).