From: Johannes Sixt <j.sixt@viscovery.net>
To: Jonathan Nieder <jrnieder@gmail.com>
Cc: Joe Ratterman <jratt0@gmail.com>,
git@vger.kernel.org, Junio C Hamano <gitster@pobox.com>,
Jeff King <peff@peff.net>
Subject: Re: [PATCH] test: errors preparing for a test are not special
Date: Wed, 14 Dec 2011 09:51:59 +0100 [thread overview]
Message-ID: <4EE863AF.2070606@viscovery.net> (raw)
In-Reply-To: <20111214082203.GB13166@elie.hsd1.il.comcast.net>
Am 12/14/2011 9:22, schrieb Jonathan Nieder:
> Johannes Sixt wrote:
>> Am 12/13/2011 23:35, schrieb Joe Ratterman:
>
>>> test_expect_success TTY 'no pager with --no-pager' '
>>> rm -f paginated.out ||
>>> cleanup_fail &&
>>
>> What kind of bogosity do I see in the context of this hunk
> [...]
>> Wouldn't rm -f always succeed under normal circumstances, and then the
>> rest of the test would be skipped?
>
> No, && and || are left-associative.
<Facepalm/> You are right, of course, and I should have known better. (I
need more caffein.)
At any rate, your patch makes the code much more comprehensible.
-- Hannes
next prev parent reply other threads:[~2011-12-14 8:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-13 22:35 [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD Joe Ratterman
2011-12-13 22:35 ` [PATCH] Add '-P' as a synonym for '--no-pager' in the git command Joe Ratterman
2011-12-14 7:44 ` Johannes Sixt
2011-12-14 8:22 ` [PATCH] test: errors preparing for a test are not special Jonathan Nieder
2011-12-14 8:51 ` Johannes Sixt [this message]
2011-12-14 9:00 ` Jonathan Nieder
2011-12-14 8:53 ` [PATCH] Gitweb: Avoid warnings when a repo does not have a valid HEAD Jonathan Nieder
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE863AF.2070606@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jratt0@gmail.com \
--cc=jrnieder@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).