From: Johannes Sixt <j.sixt@viscovery.net>
To: Brian Gernhardt <benji@silverinsanity.com>
Cc: Git List <git@vger.kernel.org>, Thomas Rast <trast@student.ethz.ch>
Subject: Re: t0090-cache-tree fails due to wc whitespace
Date: Wed, 14 Dec 2011 16:41:33 +0100 [thread overview]
Message-ID: <4EE8C3AD.9050605@viscovery.net> (raw)
In-Reply-To: <7F1792D2-8ED4-4546-8ED4-52B95E0AE9FC@silverinsanity.com>
Am 12/14/2011 15:35, schrieb Brian Gernhardt:
> It's time for my periodic complaint: People assuming `wc -l` outputs
> just a number. wc on OS X (and perhaps other BSD-like systems) always
> aligns the output in columns, even with the -l flag. Generally this
> results in a quick patch from me to remove some unneeded quotes.
> However, this time it's used in a more complex manner:
>
> echo "SHA " \
> "($(git ls-files|wc -l) entries, 0 subtrees)" >expect &&
> cmp_cache_tree expect
I'd solve it by moving the command substitution outside the quoted string:
printf "SHA (%d entries, 0 subtrees)\n" \
$(git ls-files | wc -l) >expect &&
Other proposed solutions add another process. I don't like that on Windows ;)
-- Hannes
next prev parent reply other threads:[~2011-12-14 15:41 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-14 14:35 t0090-cache-tree fails due to wc whitespace Brian Gernhardt
2011-12-14 14:57 ` Stefano Lattarini
2011-12-14 15:09 ` Hallvard Breien Furuseth
2011-12-14 15:41 ` Johannes Sixt [this message]
2011-12-20 8:24 ` [PATCH] t0090: be prepared that 'wc -l' writes leading blanks Johannes Sixt
2011-12-20 9:17 ` Thomas Rast
2011-12-14 15:43 ` t0090-cache-tree fails due to wc whitespace Thomas Rast
2011-12-14 15:54 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4EE8C3AD.9050605@viscovery.net \
--to=j.sixt@viscovery.net \
--cc=benji@silverinsanity.com \
--cc=git@vger.kernel.org \
--cc=trast@student.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).