git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Luke Diamand <luke@diamand.org>
To: Michael Horowitz <michael.horowitz@ieee.org>
Cc: Pete Wyckoff <pw@padd.com>,
	"L. A. Linden Levy" <alevy@mobitv.com>,
	git@vger.kernel.org
Subject: Re: git-p4.skipSubmitEdit
Date: Fri, 16 Dec 2011 19:50:30 +0000	[thread overview]
Message-ID: <4EEBA106.9010001@diamand.org> (raw)
In-Reply-To: <CAFLRboo8DBk3zFEBF9OqKmre=d5PM7+3J9V0pHNz53MPtqjOWA@mail.gmail.com>

On 16/12/11 15:38, Michael Horowitz wrote:
> All,
>
> It appears that this change has introduced a bug that causes submit to
> fail every time if you do not skip the submit edit.
>
>  From what I can tell, this is because the new edit_template method
> does not return True at the end.

Could you say exactly what you're doing?

I've just tried it myself and it seems to work fine:

git-p4 clone
git commit -m 'a change'
git-p4 submit
<quit from editor, with/without modifying it>

And I couldn't see any paths in edit_template that returned without a 
value of True, except the one where the user decides to bail out.

This is with Pete's skipSubmitEdit change.

Thanks!
Luke

  reply	other threads:[~2011-12-16 19:57 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-09-08 20:40 git-p4.skipSubmitEdit L. A. Linden Levy
2011-09-09 10:05 ` git-p4.skipSubmitEdit Vitor Antunes
2011-09-09 17:47   ` git-p4.skipSubmitEdit Luke Diamand
2011-09-09 17:52     ` git-p4.skipSubmitEdit L. A. Linden Levy
2011-09-10  6:10       ` git-p4.skipSubmitEdit Luke Diamand
2011-09-12  7:34 ` git-p4.skipSubmitEdit Luke Diamand
2011-09-12 17:12   ` git-p4.skipSubmitEdit L. A. Linden Levy
2011-10-18  0:45     ` git-p4.skipSubmitEdit Pete Wyckoff
2011-10-18 16:51       ` git-p4.skipSubmitEdit L. A. Linden Levy
2011-10-18 17:35         ` git-p4.skipSubmitEdit Pete Wyckoff
2011-10-18 17:53       ` git-p4.skipSubmitEdit Luke Diamand
2011-10-20  1:16         ` git-p4.skipSubmitEdit Pete Wyckoff
2011-12-16 15:38           ` git-p4.skipSubmitEdit Michael Horowitz
2011-12-16 19:50             ` Luke Diamand [this message]
2011-12-17  0:46               ` git-p4.skipSubmitEdit Michael Horowitz
2011-12-17  0:49                 ` git-p4.skipSubmitEdit Michael Horowitz
2011-12-17 17:39                   ` [PATCH] git-p4: fix skipSubmitEdit regression Pete Wyckoff

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4EEBA106.9010001@diamand.org \
    --to=luke@diamand.org \
    --cc=alevy@mobitv.com \
    --cc=git@vger.kernel.org \
    --cc=michael.horowitz@ieee.org \
    --cc=pw@padd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).