* [PATCH] builtin/log: remove redundant initialization
@ 2011-12-21 12:05 Michael Schubert
2011-12-21 19:16 ` Junio C Hamano
0 siblings, 1 reply; 2+ messages in thread
From: Michael Schubert @ 2011-12-21 12:05 UTC (permalink / raw)
To: git
"abbrev" and "commit_format" in struct rev_info get initialized in
init_revisions - no need to reinit in cmd_log_init_defaults.
Signed-off-by: Michael Schubert <mschub@elegosoft.com>
---
builtin/log.c | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/builtin/log.c b/builtin/log.c
index 89d0cc0..7d1f6f8 100644
--- a/builtin/log.c
+++ b/builtin/log.c
@@ -73,8 +73,6 @@ static int decorate_callback(const struct option *opt, const char *arg, int unse
static void cmd_log_init_defaults(struct rev_info *rev)
{
- rev->abbrev = DEFAULT_ABBREV;
- rev->commit_format = CMIT_FMT_DEFAULT;
if (fmt_pretty)
get_commit_format(fmt_pretty, rev);
rev->verbose_header = 1;
--
1.7.8.400.g03f4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] builtin/log: remove redundant initialization
2011-12-21 12:05 [PATCH] builtin/log: remove redundant initialization Michael Schubert
@ 2011-12-21 19:16 ` Junio C Hamano
0 siblings, 0 replies; 2+ messages in thread
From: Junio C Hamano @ 2011-12-21 19:16 UTC (permalink / raw)
To: Michael Schubert; +Cc: git
Thanks.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2011-12-21 19:16 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2011-12-21 12:05 [PATCH] builtin/log: remove redundant initialization Michael Schubert
2011-12-21 19:16 ` Junio C Hamano
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).