From: Michael Haggerty <mhagger@alum.mit.edu>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>,
git@vger.kernel.org, demerphq@gmail.com
Subject: Re: Bug: "git checkout -b" should be allowed in empty repo
Date: Tue, 31 Jan 2012 17:32:00 +0100 [thread overview]
Message-ID: <4F281780.1070804@alum.mit.edu> (raw)
In-Reply-To: <m3k448che9.fsf@localhost.localdomain>
On 01/31/2012 11:09 AM, Jakub Narebski wrote:
> I don't see how this can be done in backward-compatibile way.
Yes, backwards compatibility would probably prevent the NULL commit idea
from ever being implemented in a literal way.
But it is conceivable that it could be faked with some strategic
if sha1 == '0'*40:
treat_as_special_null_commit
elif len(parents) == 0:
parents = ['0'*40]
In other words, include a little special case fakery in the data
structures near root commits (an O(1) amount of work) to avoid special
cases in all commands that can touch root commits (an O(number of
commands) amount of work).
Alternatively, the NULL commit could be a UI construct that has no
manifestation in the object model. This would not save implementation
work, but would perhaps give a more consistent way to deal with root
commits in the UI than the current array of --orphan etc. options.
> Please note that in Git it is quite natural to have more than one root
> (parentless) commit, even without presence of disconnected / orphan
> branches. They are result of joining originally separate projects.
> git.git has quite a few of them (more than 6, IIRC).
I don't see the problem, unless you mean that it would be difficult to
merge repositories that don't link back to a NULL commit with
hypothetical future repositories that do include a NULL commit. But a
world in which two kinds of repositories have to be supported is
pointless anyway, because then the git code would have to include *both*
kinds of special cases and nothing would be gained.
Michael
--
Michael Haggerty
mhagger@alum.mit.edu
http://softwareswirl.blogspot.com/
prev parent reply other threads:[~2012-01-31 16:32 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-01-29 6:09 Bug: "git checkout -b" should be allowed in empty repo Michael Haggerty
2012-01-29 6:56 ` Junio C Hamano
2012-01-29 7:50 ` Junio C Hamano
2012-01-30 6:38 ` Michael Haggerty
2012-01-30 18:48 ` Junio C Hamano
2012-01-30 20:10 ` Junio C Hamano
2012-01-30 21:50 ` Jeff King
2012-02-06 2:06 ` Junio C Hamano
2012-02-06 2:08 ` Junio C Hamano
2012-02-06 4:30 ` Jeff King
2012-02-06 4:42 ` Andrew Ardill
2012-02-06 5:06 ` Jeff King
2012-02-06 8:51 ` Michael Haggerty
2012-02-06 8:57 ` Jeff King
2012-02-06 18:17 ` Junio C Hamano
2012-02-06 20:14 ` Jeff King
2012-02-07 8:04 ` Michael Haggerty
2012-02-06 18:39 ` demerphq
2012-02-06 5:15 ` Junio C Hamano
2012-02-06 5:18 ` Jeff King
2012-02-06 5:30 ` Junio C Hamano
2012-02-06 5:34 ` Junio C Hamano
2012-02-06 5:45 ` Jeff King
2012-02-06 8:59 ` Michael Haggerty
2012-02-06 18:31 ` Junio C Hamano
2012-01-30 21:48 ` Jeff King
2012-02-06 1:26 ` [PATCH] branch --edit-description: protect against mistyped branch name Junio C Hamano
2012-02-06 1:27 ` Junio C Hamano
2012-02-06 4:20 ` Jeff King
2012-01-31 8:57 ` Bug: "git checkout -b" should be allowed in empty repo Michael Haggerty
2012-01-31 10:01 ` Johannes Sixt
2012-01-31 10:11 ` demerphq
2012-01-31 10:09 ` Jakub Narebski
2012-01-31 16:32 ` Michael Haggerty [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F281780.1070804@alum.mit.edu \
--to=mhagger@alum.mit.edu \
--cc=demerphq@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).