From: "\"Wei-Yin Chen (陳威尹)\"" <chen.weiyin@gmail.com>
To: Eric Wong <normalperson@yhbt.net>
Cc: git@vger.kernel.org, Pete Harlan <pgit@pcharlan.com>, gitster@pobox.com
Subject: Re: [PATCH] git-svn: Fix time zone in --localtime
Date: Sun, 12 Feb 2012 21:49:19 +0800 [thread overview]
Message-ID: <4F37C35F.9060307@gmail.com> (raw)
In-Reply-To: <20120212081553.GA10068@dcvr.yhbt.net>
On 2012-02-12 16:15, Eric Wong wrote:
> I needed the following additional change to get things working:
>
> --- a/git-svn.perl
> +++ b/git-svn.perl
> @@ -6111,7 +6111,7 @@ sub run_pager {
>
> sub format_svn_date {
> my $t = shift || time;
> - my $gmoff = get_tz($t);
> + my $gmoff = Git::SVN::get_tz($t);
> return strftime("%Y-%m-%d %H:%M:%S $gmoff (%a, %d %b %Y)", localtime($t));
> }
Sorry, my bad. This bug of missing package reference can be triggered by
"git svn log", but unfortunately I didn't test this part manually. I'll
learn to use the git test suite next time.
>
> If there are no objections, I'll squash this and push for Junio
> tomorrow.
Excellent. Thank you for the testing and fixing effort!
prev parent reply other threads:[~2012-02-12 14:27 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-12-19 8:11 [PATCH] git-svn: Fix time zone in --localtime "Wei-Yin Chen (陳威尹)"
2012-02-12 8:15 ` Eric Wong
2012-02-12 13:49 ` "Wei-Yin Chen (陳威尹)" [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F37C35F.9060307@gmail.com \
--to=chen.weiyin@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=normalperson@yhbt.net \
--cc=pgit@pcharlan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).