From: Jens Lehmann <Jens.Lehmann@web.de>
To: Thomas Rast <trast@inf.ethz.ch>
Cc: git@vger.kernel.org
Subject: Re: git-status does not propagate -uall to submodules
Date: Fri, 17 Feb 2012 23:11:06 +0100 [thread overview]
Message-ID: <4F3ED07A.8090508@web.de> (raw)
In-Reply-To: <874nupq0la.fsf@thomas.inf.ethz.ch>
Am 17.02.2012 10:18, schrieb Thomas Rast:
> Hi,
>
> While helping with the submodule display on #git I noticed that if you
> have a submodule with status.showuntrackedfiles=no, and run 'git status
> -uall' from the superproject, then this does not propagate into the
> submodule's status. In code:
>
> $ (cd bar && git config status.showuntrackedfiles)
> no
> $ git ls-files -s
> 100644 926c01b7259c489a422442a8dc5cb5ea7c58f60c 0 .gitmodules
> 160000 eb5af46e1a938d064c9f7bae9561013654a43316 0 bar
> $ (cd bar && git status -s -unormal)
> ?? otheruntracked
> ?? untracked
> $ git status
> # On branch master
> nothing to commit (working directory clean)
>
> So far that's expected; after all the submodule is configured not to
> display untracked files. But with -uall:
>
> $ git status -uall
> # On branch master
> nothing to commit (working directory clean)
>
> Shouldn't the -uall propagate, since the user is explicitly asking for
> it? That is, the display should summarize what git-status *with the
> same arguments* would show inside the submodules?
Yes, that makes sense. In 3bfc45047 (git status: ignoring untracked
files must apply to submodules too) I added that using -uno will
propagate into submodules. But -uall (and I suspect -unormal too)
should also be passed to the status commands forked inside the
submodules (even though in both cases -unormal should suffice as only
the presence or absence of untracked files will be shown anyway).
But opposed to -uno, which overrides any diff.ignoreSubmodules or
submodule.<name>.ignore settings for the submodules, what should
-unormal and -uall do? These options are used to override the
status.showuntrackedfiles setting, so I suspect even when these
options are given submodules which are configured to ignore untracked
files via diff.ignoreSubmodules or submodule.<name>.ignore should
still be dropped, right?
prev parent reply other threads:[~2012-02-18 1:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-17 9:18 git-status does not propagate -uall to submodules Thomas Rast
2012-02-17 22:11 ` Jens Lehmann [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F3ED07A.8090508@web.de \
--to=jens.lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=trast@inf.ethz.ch \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).