From: Johannes Sixt <j6t@kdbg.org>
To: Jens Lehmann <Jens.Lehmann@web.de>
Cc: Junio C Hamano <gitster@pobox.com>,
Git Mailing List <git@vger.kernel.org>,
Antony Male <antony.male@gmail.com>,
Phil Hord <phil.hord@gmail.com>,
msysGit <msysgit@googlegroups.com>
Subject: Re: [PATCH 0/2] submodules: Use relative paths to gitdir and work tree
Date: Mon, 27 Feb 2012 22:19:19 +0100 [thread overview]
Message-ID: <4F4BF357.8020407@kdbg.org> (raw)
In-Reply-To: <4F4A8EF2.3020901@web.de>
Am 26.02.2012 20:58, schrieb Jens Lehmann:
> Am 26.02.2012 18:38, schrieb Johannes Sixt:
>> - a=$(cd "$gitdir" && pwd)
>> - b=$(cd "$path" && pwd)
>> + a=$(cd "$gitdir" && pwd -W)
>> + b=$(cd "$path" && pwd -W)
>> while [ "$b" ] && [ "${a%%/*}" = "${b%%/*}" ]
>> do
>> a=${a#*/} b=${b#*/};
>
> I don't understand why you need this. Does "pwd" sometimes return a
> path starting with "c:/" and sometimes "/c/" depending on what form
> you use when you cd into that directory?
It looks like this is the case. I was surprised as well. I hoped that
pwd -P would fix it, but it makes no difference. I should have tested
pwd -L as well, but I forgot.
> - gitdir=$(git rev-parse --git-dir)
> + gitdir=$(git rev-parse --git-dir | sed -e 's,^\([a-z]\):/,/\1/,')
I don't like pipelines of this kind because they fork yet another
process. But it looks like there are not that many alternatives...
-- Hannes
next prev parent reply other threads:[~2012-02-27 21:19 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-02-08 22:08 [PATCH 0/2] submodules: Use relative paths to gitdir and work tree Jens Lehmann
2012-02-08 22:11 ` [PATCH 1/2] submodules: always use a relative path to gitdir Jens Lehmann
2012-02-09 8:18 ` [PATCH v2 " Jens Lehmann
2012-02-09 19:40 ` Junio C Hamano
2012-02-09 19:52 ` Junio C Hamano
2012-02-09 20:13 ` Jens Lehmann
2012-02-08 22:17 ` [PATCH 2/2] submodules: always use a relative path from gitdir to work tree Jens Lehmann
2012-02-09 8:18 ` [PATCH v2 " Jens Lehmann
2012-02-13 19:59 ` Junio C Hamano
2012-02-14 17:36 ` Jens Lehmann
2012-02-14 20:24 ` Junio C Hamano
2012-02-14 20:34 ` Junio C Hamano
2012-02-15 22:18 ` Jens Lehmann
2012-02-26 17:38 ` [PATCH 0/2] submodules: Use relative paths to gitdir and " Johannes Sixt
2012-02-26 19:58 ` Jens Lehmann
2012-02-27 21:19 ` Johannes Sixt [this message]
2012-02-27 21:41 ` [msysGit] " Johannes Schindelin
2012-02-28 18:58 ` Johannes Sixt
2012-02-28 19:14 ` Junio C Hamano
2012-02-28 19:33 ` Jens Lehmann
2012-02-28 19:21 ` Jens Lehmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F4BF357.8020407@kdbg.org \
--to=j6t@kdbg.org \
--cc=Jens.Lehmann@web.de \
--cc=antony.male@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).