From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] configure: allow user to prevent $PATH "sanitization" on Solaris
Date: Fri, 09 Mar 2012 22:46:28 +0100 [thread overview]
Message-ID: <4F5A7A34.3050000@gmail.com> (raw)
In-Reply-To: <7vaa3p5zht.fsf@alter.siamese.dyndns.org>
On 03/09/2012 08:46 PM, Junio C Hamano wrote:
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
>
>> This change implements the second approach, which is less-ambitious but
>> also much less fragile.
>
> I personally think your second one is the only sane option.
>
>> ---
>
> You forgot to sign-off the patch, perhaps?
>
Indeed (but I've now fixed my git aliases to avoid similar issues in
the future). Will you fix the issue locally, or should I re-roll?
Thanks, and sorry for the noise,
Stefano
next prev parent reply other threads:[~2012-03-09 21:46 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-02 9:13 [RFC/PATCH] build: avoid possible confusion between GNU/XPG4 make on Solaris Stefano Lattarini
2012-03-02 9:34 ` Thomas Rast
2012-03-02 9:41 ` Stefano Lattarini
2012-03-02 10:18 ` [PATCH v2] " Stefano Lattarini
2012-03-02 18:35 ` [RFC/PATCH] " Junio C Hamano
2012-03-02 19:00 ` Stefano Lattarini
2012-03-02 19:46 ` Junio C Hamano
2012-03-09 12:43 ` [PATCH] configure: allow user to prevent $PATH "sanitization" " Stefano Lattarini
2012-03-09 16:29 ` Junio C Hamano
2012-03-09 19:46 ` Junio C Hamano
2012-03-09 21:46 ` Stefano Lattarini [this message]
2012-03-09 21:59 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A7A34.3050000@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).