From: Stefano Lattarini <stefano.lattarini@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] tests: modernise style: more uses of test_line_count
Date: Sat, 10 Mar 2012 00:00:07 +0100 [thread overview]
Message-ID: <4F5A8B77.7020900@gmail.com> (raw)
In-Reply-To: <7vpqcl4diw.fsf@alter.siamese.dyndns.org>
On 03/09/2012 11:26 PM, Junio C Hamano wrote:
> Stefano Lattarini <stefano.lattarini@gmail.com> writes:
>
>> This change modernizes one (and just one) kind of obsolescent idiom
>> throughout (almost) all the tests, rather than tweaking one single test
>> with lots of different and unrelated modernizations. This approach
>> seems safer, and IMHO makes for patches easier to write and review.
>
> Yes, but during the pre-release "regression fix only" period is not
> a good time to do so.
>
Sorry, I don't follow the list well enough to know when a release is imminent.
But you of course right that the maintainers shouldn't be distracted with
cosmetic/tweaking patches when a release is in preparation. I will ping this
patch once 1.7.10 is out then (and put similar patches on hold until then).
Thanks, and sorry for the noise,
Stefano
next prev parent reply other threads:[~2012-03-09 23:00 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-03-09 22:17 [PATCH] tests: modernise style: more uses of test_line_count Stefano Lattarini
2012-03-09 22:26 ` Junio C Hamano
2012-03-09 23:00 ` Stefano Lattarini [this message]
-- strict thread matches above, loose matches on Subject: below --
2012-04-11 11:24 Stefano Lattarini
2012-04-11 16:52 ` Junio C Hamano
2012-04-11 17:11 ` Junio C Hamano
2012-04-11 17:35 ` Stefano Lattarini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F5A8B77.7020900@gmail.com \
--to=stefano.lattarini@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).