git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jens Lehmann <Jens.Lehmann@web.de>
To: Tim Henigan <tim.henigan@gmail.com>
Cc: Junio C Hamano <gitster@pobox.com>, git@vger.kernel.org
Subject: Re: [PATCH 2/2] Documentation/diff-options: reword description of --submodule option
Date: Wed, 14 Mar 2012 19:47:55 +0100	[thread overview]
Message-ID: <4F60E7DB.3030808@web.de> (raw)
In-Reply-To: <CAFouetgSw7MMzHWOJox6DiPmBWD=6j4mST1KFZYsZyLmKHRrEQ@mail.gmail.com>

Am 13.03.2012 21:36, schrieb Tim Henigan:
> Some further minor changes to your version:
> 
>     Specify how differences in submodules are shown.  When `--submodule`
>     or `--submodule=log` is given, the 'log' format is used.  This format lists
>     the commits in the range like linkgit:git-submodule[1] `--summary` does.

Nit:
      the commits in the range like linkgit:git-submodule[1] `summary` does.

(`summary` is a command of "git submodule", not an option)

>     Omitting the `--submodule` option or specifying `--submodule=short`,
>     uses the 'short' format. This format just shows the names of the commits
>     at the beginning and end of the range.

But apart from that I really like it.

      reply	other threads:[~2012-03-14 18:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-13 19:00 [PATCH 1/2] Documentation/diff-options: fix typo in --submodule text Tim Henigan
2012-03-13 19:00 ` [PATCH 2/2] Documentation/diff-options: reword description of --submodule option Tim Henigan
2012-03-13 20:04   ` Junio C Hamano
2012-03-13 20:36     ` Tim Henigan
2012-03-14 18:47       ` Jens Lehmann [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F60E7DB.3030808@web.de \
    --to=jens.lehmann@web.de \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=tim.henigan@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).