git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Namhyung Kim <namhyung.kim@lge.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 2/3] help: Add '--follow-alias' option
Date: Thu, 15 Mar 2012 15:46:30 +0900	[thread overview]
Message-ID: <4F619046.1050308@lge.com> (raw)
In-Reply-To: <7vvcm6l6w0.fsf@alter.siamese.dyndns.org>

2012-03-15 3:23 PM, Junio C Hamano wrote:
> 김남형 <namhyung.kim@lge.com> writes:
>> 2012-03-15 3:00 PM, Junio C Hamano wrote:
>>> Namhyung Kim <namhyung.kim@lge.com> writes:
>>>
>>>> The --follow-alias option will look up the alias definitions and
>>>> use the first word as a command. For example, if I set my aliases
>>>> as follows:
>>>>
>>>>    $ git help br
>>>>    `git br' is aliased to `git branch'
>>>>    $ git help ru
>>>>    `git ru' is aliased to `git remote update'
>>>>
>>>> adding --follow-alias (or -f) option will show man pages of
>>>> git-branch and git-remote, respectively.
>>>
>>> What would happen when somebody has this?
>>>
>>> 	[alias]
>>>           	br = branch --list
>>>
>>> 	$ git help --follow-alias br
>>> 	... man page for git-branch is shown ...
>>>
>>> NAK.
>>
>> I'm sorry I don't understand what you meant by this. What should be
>> happened for this?
>
> You _somehow_ restict the output, or at least draw the user's attention,
> to the description of --list mode in the resulting "git-branch" manual.
>
> I do not think that is feasible.
>

Actually I was thinking about moving to an appropriate point in the document 
by checking second argument (if any) and searching it (using regexp?). But I 
coundn't be sure it'd be possible too.


> But showing the whole manual page, without telling the user that "br" is
> not aliased to a plain vanilla "branch" without any option, is not a
> solution, especially if you are going to let the user set a configuration
> variable to allow him to forget about this setting. Progressive revelation
> would not have such a downside and I think it is more appropriate approach
> for something like "help".
>

OK. That makes sense to me too. This was just a quick thought hoping that can 
be helpful for someone who uses alias as a simple abbreviation.

Thanks for taking your time and giving me detailed comments.
Namhyung

  reply	other threads:[~2012-03-15  6:46 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-15  2:52 [PATCH 1/3] help: Fix help message for aliases Namhyung Kim
2012-03-15  2:52 ` [PATCH 2/3] help: Add '--follow-alias' option Namhyung Kim
2012-03-15  6:00   ` Junio C Hamano
2012-03-15  6:15     ` 김남형
2012-03-15  6:23       ` Junio C Hamano
2012-03-15  6:46         ` Namhyung Kim [this message]
2012-03-15  7:09           ` Junio C Hamano
2012-03-15  2:52 ` [PATCH 3/3] help: Add 'help.follow-alias' config item Namhyung Kim
2012-03-15  6:06   ` Junio C Hamano
2012-03-15  6:29     ` Namhyung Kim
2012-03-15  4:17 ` [PATCH 1/3] help: Fix help message for aliases Jeff King
2012-03-15  5:15   ` 김남형
2012-03-15 13:19     ` Jeff King
2012-03-15  5:23 ` Junio C Hamano
2012-03-15  5:48   ` 김남형
2012-03-15  6:18     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F619046.1050308@lge.com \
    --to=namhyung.kim@lge.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).