Re: [PATCH] rebase -i: inform the user they can re-order commits

[Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es>]

On 03/16/2012 01:17 PM, Junio C Hamano wrote:
> Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes:
> 
>> Nelson Benitez Leon <nelsonjesus.benitez@seap.minhap.es> writes:
>>
>>> +# You can re-order the commit lines to affect the order on which
>>> +# the commits will be applied.
>>
>> That's probably the main use of "rebase -i", so it deserves a mention,
>> yes.
> 
> Erm, read in isolation by people like you who _know_ what the command
> does, the addition might look sensible, but I find that line of thinking
> somewhat disturbing in the first place.
> 
> These are meant to be a short _reminder_ for people who _learned_ how the
> command they already _know_ is spelled.
> 
> If the user does not even know that one of the primary use of the command
> is to reorder, isn't he playing with fire?

In an ideal world everybody should study the manpages and documentation of
a program prior to using it, unfortunately most people often start with an
easy-to-follow tutorial where there are commands to type in, the user
will type them (confident in the tutorial reputation) and try to learn along
the way, in this case giving the user more indications about what he can 
do in any moment is, in my opinion, a good thing (as git already does). 


> If we come up with a politely worded message that makes the user realize
> that the user does not know what he is doing and gently nudges the user to
> read the documentation before continuing to potentially harm himself, that
> would be a good addition, but...
> 
> So, I dunno.