git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Neal Kreitzinger <nkreitzinger@gmail.com>
To: Jeff King <peff@peff.net>
Cc: Chris Patti <cpatti@gmail.com>, git@vger.kernel.org
Subject: Re: Has anyone written a hook to block fast forward merges to a branch?
Date: Wed, 21 Mar 2012 16:14:21 -0500	[thread overview]
Message-ID: <4F6A44AD.4040600@gmail.com> (raw)
In-Reply-To: <20120321204333.GB15021@sigill.intra.peff.net>

On 3/21/2012 3:43 PM, Jeff King wrote:
> On Wed, Mar 21, 2012 at 03:32:10PM -0500, Neal Kreitzinger wrote:
>
>> On 3/21/2012 1:22 PM, Chris Patti wrote:
>>> I know there are hooks out there to block various other kinds of
>>> change, but I was wondering if anyone had specifically ever
>>> written one to block fast forward merges.
>>>
>> Maybe git-merge --no-ff would also be helpful to "do what you
>> want".
>
> When I wrote my response, I assumed the intent was that people
> _should_ be using --no-ff, but that he wanted to enforce it via hook
> during a push to a central repository.
>
> Reading it again, I'm not sure whether that is the case or not. If
> not, the disregard my original response. :)
>
Would your script only work at "push time", or would it also work at
"commit time"?  I'm not sure at what point he thinks he wants to enforce 
it.  I don't think git yet knows the info your script is asking for at 
"commit time" (ie, pre-commit hook and its brethren), and by the time it 
does know it's too late to block the commit locally.  Maybe it does know 
that inof at the point one of those "commit time" hooks runs.  I haven't 
tried it.

v/r,
neal

  reply	other threads:[~2012-03-21 21:14 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-21 18:22 Has anyone written a hook to block fast forward merges to a branch? Chris Patti
2012-03-21 18:40 ` Jeff King
2012-03-21 20:32 ` Neal Kreitzinger
2012-03-21 20:43   ` Jeff King
2012-03-21 21:14     ` Neal Kreitzinger [this message]
2012-03-21 21:22       ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F6A44AD.4040600@gmail.com \
    --to=nkreitzinger@gmail.com \
    --cc=cpatti@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).