From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ivan Todoroski Subject: Re: [PATCH/RFC v2 1/4] fetch-pack: new --stdin option to read refs from stdin Date: Wed, 28 Mar 2012 01:48:11 +0200 Message-ID: <4F7251BB.5010406@gmx.net> References: <20120318190659.GA24829@sigill.intra.peff.net> <20120319024436.GB10426@sigill.intra.peff.net> <4F69B5F0.2060605@gmx.net> <20120321171423.GA13140@sigill.intra.peff.net> <4F715CF7.5070903@gmx.net> <4F715D55.8020109@gmx.net> <7vhaxaj7yi.fsf@alter.siamese.dyndns.org> <4F724ADC.2030909@gmx.net> <7vwr65y6b6.fsf@alter.siamese.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: Jeff King , Shawn Pearce , Nguyen Thai Ngoc Duy , Jakub Narebski , git@vger.kernel.org To: Junio C Hamano X-From: git-owner@vger.kernel.org Wed Mar 28 01:48:18 2012 Return-path: Envelope-to: gcvg-git-2@plane.gmane.org Received: from vger.kernel.org ([209.132.180.67]) by plane.gmane.org with esmtp (Exim 4.69) (envelope-from ) id 1SCg7e-0003mE-1F for gcvg-git-2@plane.gmane.org; Wed, 28 Mar 2012 01:48:18 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756123Ab2C0XsP (ORCPT ); Tue, 27 Mar 2012 19:48:15 -0400 Received: from mailout-de.gmx.net ([213.165.64.23]:38810 "HELO mailout-de.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1755916Ab2C0XsO (ORCPT ); Tue, 27 Mar 2012 19:48:14 -0400 Received: (qmail invoked by alias); 27 Mar 2012 23:48:12 -0000 Received: from unknown (EHLO [127.0.0.1]) [77.28.166.58] by mail.gmx.net (mp031) with SMTP; 28 Mar 2012 01:48:12 +0200 X-Authenticated: #7905487 X-Provags-ID: V01U2FsdGVkX1+qi88/ywGqrxWaXbkCLHSZciT0fRODHr2VZiPFTA UvCEgtlEq1m2wW User-Agent: Thunderbird 2.0.0.24 (Windows/20100228) In-Reply-To: <7vwr65y6b6.fsf@alter.siamese.dyndns.org> X-Y-GMX-Trusted: 0 Sender: git-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: git@vger.kernel.org Archived-At: On 28.03.2012 01:26, Junio C Hamano wrote: > Ivan Todoroski writes: > >>> Curious. "stop at EOF", "trim" and "skip empty" imply that you are >>> catering to people who debug this from the terminal by typing (or copy >>> pasting). Is that the expected use case? >> The expected use case is people using this from shell scripts that >> could be getting refs by slicing and dicing output of other commands >> with regexps and what not > > That kind of use would not have leading or trailing whitespaces, and if > the target audience is scripts, I would prefer to force them to be > strict. Depends on how good the script writer is. :) But you're right, they can always change the script to tighten up what it generates. Also, I just checked what other commands with --stdin flags do (like rev-list, checkout-index, etc). They all expect an exact format like you said and they don't tolerate extra whitespace, making my patch the odd one out. It is important that similar flags behave consistently across different commands. Sorry for not checking for precedent before deciding to tolerate whitespace. I will tighten it up.