git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrew Sayers <andrew-20120330@pileofstuff.org>
To: Jakub Narebski <jnareb@gmail.com>
Cc: Jeff King <peff@peff.net>, jaseem abid <jaseemabid@gmail.com>,
	git@vger.kernel.org
Subject: Re: [GSOC] Contributing to git.
Date: Fri, 30 Mar 2012 23:39:16 +0100	[thread overview]
Message-ID: <4F763614.1010503@pileofstuff.org> (raw)
In-Reply-To: <201203301305.23567.jnareb@gmail.com>

On 30/03/12 12:05, Jakub Narebski wrote:
> But even if the JavaScript tests would have to be run in browser (like
> most of all of them seems to), having any automated test for gitweb's 
> JavaScript code would be a very good idea.
> 
> P.S. I wonder how JavaScript-scriptable Veracity DVCS solved that...

JS test suites generally run in the browser because knowing that your
tests pass in some sane command-line compiler tells you nothing about
how it will be mangled by IE (or in rare cases, other browsers).

IMHO, the best thing to do with JS unit tests would be to make them
easily available from gitweb.  Then when someone reports a bug, you just
ask them to run the tests in their browser - the pattern of errors will
quickly show you that e.g. their AdBlock filters are getting a bit
overexcited about all these `git add`s it can remove (that sort of thing
was a frequently-reported problem at my last job).

Obviously it's good to run tests automatically too - you might want to
consider writing tests with QUnit[1] and automating them with
Selenium[2].  The former is designed to be appealing to human eyes and
trivially testable with the latter (although I'd expect other suites to
include the necessary <div>s with the necessary id's too).  I haven't
used the Perl interface myself, but I'm sure you could make some TAP
output with WWW::Selenium pretty easily.

	- Andrew

1. http://docs.jquery.com/QUnit
2. http://seleniumhq.org/

      parent reply	other threads:[~2012-03-30 22:39 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-03-30  2:49 [GSOC] Contributing to git jaseem abid
2012-03-30  5:26 ` Jeff King
2012-03-30 10:24   ` jaseem abid
2012-03-30 11:05   ` Jakub Narebski
2012-03-30 11:18     ` chaitanyaa nalla
2012-03-30 11:45       ` Jakub Narebski
2012-03-30 11:51         ` chaitanyaa nalla
2012-03-30 12:49       ` jaseem abid
2012-03-30 12:46     ` jaseem abid
2012-03-30 23:37       ` Jakub Narebski
2012-04-02  7:32         ` Nazri Ramliy
2012-04-02 16:26           ` jaseem abid
2012-04-03  1:39             ` Nazri Ramliy
2012-04-03  9:03               ` Jakub Narebski
2012-03-30 22:39     ` Andrew Sayers [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F763614.1010503@pileofstuff.org \
    --to=andrew-20120330@pileofstuff.org \
    --cc=git@vger.kernel.org \
    --cc=jaseemabid@gmail.com \
    --cc=jnareb@gmail.com \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).