git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Sebastian Pipping <sebastian@pipping.org>
To: Git ML <git@vger.kernel.org>
Subject: [PATCH] Gitweb: Fix unintended "--no-merges" for regular Atom feed
Date: Mon, 02 Apr 2012 18:44:29 +0200	[thread overview]
Message-ID: <4F79D76D.80805@pipping.org> (raw)

[-- Attachment #1: Type: text/plain, Size: 117 bytes --]

Hello!


Please excuse that I send the patch as an attachment and consider
application.  Thanks!

Best,



Sebastian

[-- Attachment #2: 0001-Gitweb-Fix-unintended-no-merges-for-regular-Atom-fee.patch --]
[-- Type: text/x-patch, Size: 1196 bytes --]

>From 03bed689671df47040c4a0ad158c0c9b039a50bf Mon Sep 17 00:00:00 2001
From: Sebastian Pipping <sebastian@pipping.org>
Date: Mon, 2 Apr 2012 18:39:48 +0200
Subject: [PATCH] Gitweb: Fix unintended "--no-merges" for regular Atom feed

Before:
<link rel="alternate" title="[..] - Atom feed" href="/?p=.git;a=atom;opt=--no-merges" type="application/atom+xml" />
<link rel="alternate" title="[..] - Atom feed (no merges)" href="/?p=.git;a=atom;opt=--no-merges" type="application/atom+xml" />

After:
<link rel="alternate" title="[..] - Atom feed" href="/?p=.git;a=atom;opt=" type="application/atom+xml" />
<link rel="alternate" title="[..] - Atom feed (no merges)" href="/?p=.git;a=atom;opt=--no-merges" type="application/atom+xml" />
---
 gitweb/gitweb.perl |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index a8b5fad..cc45ae3 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -3886,6 +3886,7 @@ sub print_feed_meta {
 				'-type' => "application/$type+xml"
 			);
 
+			$href_params{'extra_options'} = '';
 			$href_params{'action'} = $type;
 			$link_attr{'-href'} = href(%href_params);
 			print "<link ".
-- 
1.7.8.5


             reply	other threads:[~2012-04-02 16:51 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-04-02 16:44 Sebastian Pipping [this message]
2012-04-04 12:25 ` [PATCH (bugfix)] gitweb: Fix unintended "--no-merges" for regular Atom feed Jakub Narebski
2012-04-04 17:47   ` Junio C Hamano
2012-04-04 18:58     ` Jakub Narebski
2012-04-11 15:39       ` Jakub Narebski
2012-04-11 16:48         ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4F79D76D.80805@pipping.org \
    --to=sebastian@pipping.org \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).