From: Ross Lagerwall <rosslagerwall@gmail.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] stash: don't leak underlying error messages
Date: Fri, 13 Apr 2012 05:59:54 +0200 [thread overview]
Message-ID: <4F87A4BA.50009@gmail.com> (raw)
In-Reply-To: <7vaa2g694j.fsf@alter.siamese.dyndns.org>
[-- Attachment #1: Type: text/plain, Size: 867 bytes --]
On 04/12/2012 09:30 PM, Junio C Hamano wrote:
> Sign-off?
Oops, I'm not really used to the whole sign-off thing.
> Is create_stash (hence save_stash) the only operation that do not make
> sense when HEAD is not born yet? I am wondering if it makes more sense to
> either:
>
> (1) catch the case where HEAD is not born yet a lot earlier and do not
> let the control even reach these functions (i.e. die inside the
> case/esac statement at the end of the script); or
>
> (2) pretend as if HEAD is a commit that records an empty tree, and not
> error out to begin with.
>
> If either one of the above turns out to make sense, then the issue this
> patch addresses becomes irrelevant, so...
I think it would be more consistent if stash worked without any commits
having taken place so I'll look at (2).
--
Ross Lagerwall
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 294 bytes --]
prev parent reply other threads:[~2012-04-13 4:01 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-11 18:36 [PATCH] stash: don't leak underlying error messages Ross Lagerwall
2012-04-12 19:30 ` Junio C Hamano
2012-04-13 3:59 ` Ross Lagerwall [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F87A4BA.50009@gmail.com \
--to=rosslagerwall@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).