From: Johannes Sixt <j6t@kdbg.org>
To: Ramsay Jones <ramsay@ramsay1.demon.co.uk>
Cc: Jens Lehmann <Jens.Lehmann@web.de>,
Junio C Hamano <gitster@pobox.com>,
bwalton@artsci.utoronto.ca, avarab@gmail.com,
GIT Mailing-list <git@vger.kernel.org>
Subject: Re: [PATCH] git-submodule.sh: Don't use $path variable in eval_gettext string
Date: Wed, 18 Apr 2012 20:11:19 +0200 [thread overview]
Message-ID: <4F8F03C7.7000309@kdbg.org> (raw)
In-Reply-To: <4F8EA009.5080405@web.de>
Am 18.04.2012 13:05, schrieb Jens Lehmann:
> Am 17.04.2012 20:00, schrieb Ramsay Jones:
>> In particular, when executing test #38 in t7400-submodule-basic.sh,
>> an 'git-sh-i18n-envsubst.exe - Unable To Locate Component' dialog
>> pops up saying that the application "failed to start because
>> libiconv2.dll was not found."
I also observed this error, and this patch fixes it (and at that also
passes the test suite).
Thanks, Ramsay!
-- Hannes
next prev parent reply other threads:[~2012-04-18 18:11 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-17 18:00 [PATCH] git-submodule.sh: Don't use $path variable in eval_gettext string Ramsay Jones
2012-04-18 11:05 ` Jens Lehmann
2012-04-18 18:11 ` Johannes Sixt [this message]
2012-04-18 20:06 ` Ramsay Jones
2012-04-18 23:42 ` Junio C Hamano
2012-04-24 17:32 ` Ramsay Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F8F03C7.7000309@kdbg.org \
--to=j6t@kdbg.org \
--cc=Jens.Lehmann@web.de \
--cc=avarab@gmail.com \
--cc=bwalton@artsci.utoronto.ca \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=ramsay@ramsay1.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).