From: Jens Lehmann <Jens.Lehmann@web.de>
To: Junio C Hamano <gitster@pobox.com>
Cc: Antonin Hildebrand <antonin@hildebrand.cz>, git@vger.kernel.org
Subject: Re: contrib/workdir/git-new-workdir broken in 1.7.10 after introducing gitfiles
Date: Sun, 22 Apr 2012 20:32:18 +0200 [thread overview]
Message-ID: <4F944EB2.6040105@web.de> (raw)
In-Reply-To: <xmqqy5poxtsc.fsf@junio.mtv.corp.google.com>
Am 22.04.2012 06:41, schrieb Junio C Hamano:
> Junio C Hamano <gitster@pobox.com> writes:
>
>> As you analyzed correctly, core.worktree lets a GIT_DIR to declare that
>> there is a single working tree associated with it. It fundamentally is
>> incompatible with new-workdir, which is a hack to let more than one
>> working tree associated with a single GIT_DIR.
>>
>> I however do not think a simplistic "unset core.worktree" is a good
>> suggestion, though, as we do not know why the original repository has
>> that variable set pointing at somewhere. Blindly removing it will break
>> the use of the original repository. If somebody _really_ wants to use
>> new-workdir for whatever reason in such a setting, I would imagine that
>> doing something like this:
>> ...
>> may work.
>
> I am too lazy to try it out myself, but a hack something along the line
> of the attached patch _might_ turn out to work well.
A quick test worked just fine. Looks like you fixed git-new-workdir to
be usable with the new gitfile submodules ;-)
next prev parent reply other threads:[~2012-04-22 18:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-20 20:16 contrib/workdir/git-new-workdir broken in 1.7.10 after introducing gitfiles Antonin Hildebrand
2012-04-21 18:45 ` Jens Lehmann
2012-04-21 19:51 ` Junio C Hamano
2012-04-22 3:56 ` Antonin Hildebrand
2012-04-22 4:41 ` Junio C Hamano
2012-04-22 18:32 ` Jens Lehmann [this message]
2012-04-22 18:58 ` Mark Levedahl
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F944EB2.6040105@web.de \
--to=jens.lehmann@web.de \
--cc=antonin@hildebrand.cz \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).