From: "René Scharfe" <rene.scharfe@lsrfire.ath.cx>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jeff King <peff@peff.net>,
Michael Mueller <mmueller@vigilantsw.com>,
Ramkumar Ramachandra <artagnon@gmail.com>
Subject: Re: [PATCH 1/3] sequencer: export commit_list_append()
Date: Mon, 30 Apr 2012 23:07:21 +0200 [thread overview]
Message-ID: <4F9EFF09.5010201@lsrfire.ath.cx> (raw)
In-Reply-To: <xmqqobqfbhae.fsf@junio.mtv.corp.google.com>
Am 26.04.2012 00:03, schrieb Junio C Hamano:
> I however wonder if we can name "next" a bit better, but cannot come up
> with a good name. It is the location that holds the pointer to the new
> tail element if we append one. Some places may call it "tail" but that
> gives a wrong impression that it points at the element at the end.
Perhaps tail_next? And it's perhaps a good idea to include it in the
struct instead of letting callers maintain it separately.
René
next prev parent reply other threads:[~2012-04-30 21:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-04-25 7:59 Possible segfault introduced in commit.c Michael Mueller
2012-04-25 11:14 ` Jeff King
2012-04-25 20:22 ` René Scharfe
2012-04-25 20:35 ` [PATCH 1/3] sequencer: export commit_list_append() René Scharfe
2012-04-25 22:03 ` Junio C Hamano
2012-04-30 21:07 ` René Scharfe [this message]
2012-04-25 20:35 ` [PATCH 2/3] revision: append to list instead of insert and reverse René Scharfe
2012-04-25 20:35 ` [PATCH 3/3] commit: remove commit_list_reverse() René Scharfe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4F9EFF09.5010201@lsrfire.ath.cx \
--to=rene.scharfe@lsrfire.ath.cx \
--cc=artagnon@gmail.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=mmueller@vigilantsw.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).