From: "Torsten Bögershausen" <tboegi@web.de>
To: Jeff King <peff@peff.net>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>,
"Junio C Hamano" <gitster@pobox.com>,
"Torsten Bögershausen" <tboegi@web.de>,
jnareb@gmail.com, git@vger.kernel.org
Subject: Re: [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin
Date: Tue, 01 May 2012 19:50:44 +0200 [thread overview]
Message-ID: <4FA02274.6070601@web.de> (raw)
In-Reply-To: <20120501170810.GA22444@sigill.intra.peff.net>
Thanks for all answers,
> I think the patch we want is just:
>
> diff --git a/t/gitweb-lib.sh b/t/gitweb-lib.sh
> index 21d11d6..ae2dc46 100644
> --- a/t/gitweb-lib.sh
> +++ b/t/gitweb-lib.sh
> @@ -69,7 +69,7 @@ gitweb_run () {
> # written to web server logs, so we are not interested in that:
> # we are interested only in properly formatted errors/warnings
> rm -f gitweb.log &&
> - perl -- "$SCRIPT_NAME" \
> + "$PERL_PATH" -- "$SCRIPT_NAME" \
> >gitweb.output 2>gitweb.log &&
> perl -w -e '
> open O, ">gitweb.headers";
>
> no? Torsten, does that fix your problem?
Yes, it does.
Should we go for that solution ?
/Torsten
next prev parent reply other threads:[~2012-05-01 17:50 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-05-01 11:23 [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin Torsten Bögershausen
2012-05-01 16:23 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 16:34 ` Jeff King
2012-05-01 16:47 ` Junio C Hamano
2012-05-01 17:03 ` Zbigniew Jędrzejewski-Szmek
2012-05-01 17:08 ` Jeff King
2012-05-01 17:50 ` Torsten Bögershausen [this message]
2012-05-01 17:53 ` Junio C Hamano
2012-05-01 17:55 ` [PATCH] t/gitweb-lib: use $PERL_PATH to run gitweb Jeff King
2012-05-01 20:18 ` [PATCH] Consistently use perl from /usr/bin/ for scripts Zbigniew Jędrzejewski-Szmek
2012-05-01 20:54 ` Randal L. Schwartz
2012-05-01 16:44 ` [PATCH] gitweb-lib.sh: Set up PATH to use perl from /usr/bin Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA02274.6070601@web.de \
--to=tboegi@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=jnareb@gmail.com \
--cc=peff@peff.net \
--cc=zbyszek@in.waw.pl \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).