From: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>
To: Jeff King <peff@peff.net>
Cc: Clemens Buchacher <drizzd@aon.at>,
Junio C Hamano <gitster@pobox.com>, dfowler <davidfowl@gmail.com>,
git@vger.kernel.org, msysgit@googlegroups.com,
Paul Betts <paul@github.com>, David Ebbo <david.ebbo@gmail.com>
Subject: Re: [PATCH 3/3] t5541: test more combinations of --progress
Date: Tue, 01 May 2012 22:45:00 +0200 [thread overview]
Message-ID: <4FA04B4C.4090507@in.waw.pl> (raw)
In-Reply-To: <20120501084307.GC4998@sigill.intra.peff.net>
On 05/01/2012 10:43 AM, Jeff King wrote:
> -test_expect_success TTY 'quiet push' '
> +test_expect_success TTY 'push shows progress when stderr is a tty' '
> + cd "$ROOT_PATH"/test_repo_clone &&
> + test_commit noisy &&
> + test_terminal git push 2>&1 | tee output &&
> + grep "^Writing objects" output
> +'
> +
> +test_expect_success TTY 'push --quiet silences status and progress' '
> cd "$ROOT_PATH"/test_repo_clone &&
> test_commit quiet &&
> - test_terminal git push --quiet --no-progress 2>&1 | tee output &&
> + test_terminal git push --quiet 2>&1 | tee output &&
> test_cmp /dev/null output
> '
>
> +test_expect_success TTY 'push --no-progress silences progress but not status' '
> + cd "$ROOT_PATH"/test_repo_clone &&
> + test_commit no-progress &&
> + test_terminal git push --no-progress 2>&1 | tee output &&
> + grep "^To http" output &&
> + ! grep "^Writing objects"
! grep "^Writing objects" output
> +'
> +
> +test_expect_success 'push --progress shows progress to non-tty' '
> + cd "$ROOT_PATH"/test_repo_clone &&
> + test_commit progress &&
> + git push --progress 2>&1 | tee output &&
> + grep "^To http" output &&
> + grep "^Writing objects" output
> +'
> +
I understand that test_i18ngrep is not necessary, because pack-objects.c
is not internationalized. But wouldn't it make sense to use
test_i18ngrep in preparation, so that tests don't have to be modified
later on?
-
Zbyszek
next prev parent reply other threads:[~2012-05-01 20:45 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20120501010609.GA14715@jupiter.local>
2012-05-01 6:58 ` 1.7.10 doesn't show file pushstatus Jeff King
2012-05-01 7:33 ` Jeff King
2012-05-01 8:40 ` Jeff King
2012-05-01 8:41 ` [PATCH 1/3] send-pack: show progress when isatty(2) Jeff King
2012-05-01 8:42 ` [PATCH 2/3] teach send-pack about --[no-]progress Jeff King
2012-05-01 8:43 ` [PATCH 3/3] t5541: test more combinations of --progress Jeff King
2012-05-01 9:35 ` Clemens Buchacher
2012-05-01 9:37 ` Jeff King
2012-05-01 17:53 ` David Ebbo
2012-05-01 20:45 ` Zbigniew Jędrzejewski-Szmek [this message]
2012-05-01 20:53 ` Junio C Hamano
2012-05-01 9:32 ` 1.7.10 doesn't show file pushstatus Clemens Buchacher
2012-05-01 17:33 ` Junio C Hamano
2012-05-02 1:04 ` Johannes Schindelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FA04B4C.4090507@in.waw.pl \
--to=zbyszek@in.waw.pl \
--cc=david.ebbo@gmail.com \
--cc=davidfowl@gmail.com \
--cc=drizzd@aon.at \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=msysgit@googlegroups.com \
--cc=paul@github.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).