git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Vincent van Ravesteijn <vfr@lyx.org>
To: Johannes Sixt <j.sixt@viscovery.net>
Cc: "Zbigniew Jędrzejewski-Szmek" <zbyszek@in.waw.pl>, git@vger.kernel.org
Subject: Re: [PATCH] Collocate strings to simplify translation
Date: Thu, 24 May 2012 14:34:01 +0200	[thread overview]
Message-ID: <4FBE2AB9.6010502@lyx.org> (raw)
In-Reply-To: <4FBE2797.80505@viscovery.net>

Op 24-5-2012 14:20, Johannes Sixt schreef:
> Am 5/24/2012 11:55, schrieb Vincent van Ravesteijn:
>> Op 24-5-2012 10:32, Zbigniew Jędrzejewski-Szmek schreef:
>>> On 05/24/2012 09:41 AM, Vincent van Ravesteijn wrote:
>>>> -    status_printf_ln(s, c, _("%s files:"), what);
>>>> +    status_printf_ln(s, c, _("%s:"), what);
>>> How can "%s:" be translated? _() should be removed here.
>> Some languages might use a character different from ':'. For example,
>> Chinese uses a full-width character ':' (unicode 0xFF1A) instead of a
>> half-width character. Maybe this is taken care of by the system/shell or
>> whatever, maybe not. Other examples are languages that read from right to
>> left. I guess it should then be translated by ":%s".
>>
>> This will probably be a matter of convention.
> Shouldn't you then move the colon with the "files"? That is, here we have:
>
> -	status_printf_ln(s, c, _("%s files:"), what);
> +	status_printf_ln(s, c, "%s", what);
>
> and elsewhere we use _("Untracked files:") and _("Ignored files:").

I would avoid having too many 'decorations' in the strings themselves, 
because it is annoying to have to translate "Untracked files", 
"untracked files", "untracked files:", "  (untracked files)" etc.

Besides, the translation of "%s:" can be reused numerous times.

Just my opinion.

Vincent

      reply	other threads:[~2012-05-24 12:34 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2012-05-24  7:41 [PATCH] Collocate strings to simplify translation Vincent van Ravesteijn
2012-05-24  8:32 ` Zbigniew Jędrzejewski-Szmek
2012-05-24  9:55   ` Vincent van Ravesteijn
2012-05-24 12:20     ` Johannes Sixt
2012-05-24 12:34       ` Vincent van Ravesteijn [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4FBE2AB9.6010502@lyx.org \
    --to=vfr@lyx.org \
    --cc=git@vger.kernel.org \
    --cc=j.sixt@viscovery.net \
    --cc=zbyszek@in.waw.pl \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).