* Re: [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config
@ 2012-06-01 19:49 nguyenhu
2012-06-04 17:27 ` Ramsay Jones
0 siblings, 1 reply; 6+ messages in thread
From: nguyenhu @ 2012-06-01 19:49 UTC (permalink / raw)
To: ramsay; +Cc: git
Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes:
> I have not tried this patch (or the v3 version, which I haven't read
> yet), but
> is it likely that this has re-introduced the bug addressed by commit 05bab3ea
> ("config.c: Fix a static buffer overwrite bug by avoiding mkpath()",
> >19-11-2011)?.
>
> I don't know the answer, but I suspect that it may have done just
> that. >(indeed, it
> may well have made the bug more likely to appear).
>
>
>> The original that read from $HOME/.gitconfig was simple enough so
>> having three copies of getenv("HOME") was perfectly fine, but as you
>> are introduce this much complexity to to decide which two files to
>> read from, the code added this patch needs to be refactored and
>> three copies of the same logic need to be consolidated, I would have
>> to say.
>
> I agree. Also, using mksnpath() in the refactored code (rather than
> mkpath()) would be a good idea. :-P
>
> ATB,
> Ramsay Jones
Is not mkpath() the same function as mksnpath with char *buff =
buf[PATH_MAX] and size_t n = sizeof(buf) ?
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config 2012-06-01 19:49 [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config nguyenhu @ 2012-06-04 17:27 ` Ramsay Jones 0 siblings, 0 replies; 6+ messages in thread From: Ramsay Jones @ 2012-06-04 17:27 UTC (permalink / raw) To: nguyenhu; +Cc: git, Junio C Hamano nguyenhu@minatec.inpg.fr wrote: > Ramsay Jones <ramsay@ramsay1.demon.co.uk> writes: >> I have not tried this patch (or the v3 version, which I haven't read >> yet), but >> is it likely that this has re-introduced the bug addressed by commit 05bab3ea >> ("config.c: Fix a static buffer overwrite bug by avoiding mkpath()", >>> 19-11-2011)?. >> I don't know the answer, but I suspect that it may have done just >> that. >(indeed, it >> may well have made the bug more likely to appear). >> >> >>> The original that read from $HOME/.gitconfig was simple enough so >>> having three copies of getenv("HOME") was perfectly fine, but as you >>> are introduce this much complexity to to decide which two files to >>> read from, the code added this patch needs to be refactored and >>> three copies of the same logic need to be consolidated, I would have >>> to say. >> I agree. Also, using mksnpath() in the refactored code (rather than >> mkpath()) would be a good idea. :-P >> >> ATB, >> Ramsay Jones > > Is not mkpath() the same function as mksnpath with char *buff = > buf[PATH_MAX] and size_t n = sizeof(buf) ? I'm sorry but I just can't understand your question. :( Have you looked at commit 05bab3ea? Is the commit message unclear? The main difference between mkpath() and mksnpath(), as far as this bug is concerned, is that mkpath() returns a reference to *recycled* internal static buffers, whereas mksnpath() does not (you provide your own). This evening I finally had a look at your patch, well v4 of the patch, and I can confirm that it does indeed re-introduce the bug. I will reply to the v4 patch email with more comments. HTH ATB, Ramsay Jones ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config @ 2012-05-31 8:46 nguyenhu 0 siblings, 0 replies; 6+ messages in thread From: nguyenhu @ 2012-05-31 8:46 UTC (permalink / raw) To: Junio C Hamano, Matthieu Moy Cc: git, Lucien KONG, Valentin DUPERRAY, Thomas NGUY, Franck JONAS Junio C Hamano <gitster@pobox.com> wrote: > Is it just me who finds the above three lines extremely unreadable? > > Also can you give this patch a bit more sensible title? > "Possibility to" does not tell us much---anything is possible if you > change code after all. > > I see the patch does not touch the writing codepath, which is > probably a good thing, but the log message should explicitly state > that. I will change that in my next version. > I am not sure in what way $HOME/.gitconfig has "priority". > > Your proposed log message says that You read from $HOME/.gitconfig > and then from $XDG_CONFIG_HOME/git/config, which means that any > single-valued variable set in $HOME/.gitconfig will be overwritten > by whatever is in $XDG_CONFIG_HOME/git/config, no? That sounds like > you are giving priority to the latter to me. You are right. Git takes into account $HOME/.gitconfig if one variable is defined in both configuration files. I will explains that more clearly in documentation. > The original that read from $HOME/.gitconfig was simple enough so > having three copies of getenv("HOME") was perfectly fine, but as you > are introduce this much complexity to to decide which two files to > read from, the code added this patch needs to be refactored and > three copies of the same logic need to be consolidated, I would have > to say. Matthieu Moy <Matthieu.Moy@grenoble-inp.fr> writes: > Shouldn't there be a helper function to get the path ~/.config/git/ > and then append config? You're already computing this path twice, and > we'll need more instances of it if we want to give default values to > core.excludesfile and core.attributesfile in this directory too. I agree. I will write a function to get ~/.config/git/ and refactor code. ^ permalink raw reply [flat|nested] 6+ messages in thread
[parent not found: <1338400509-26087-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>]
* [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config [not found] <1338400509-26087-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> @ 2012-05-30 21:19 ` Huynh Khoi Nguyen NGUYEN 2012-05-30 21:54 ` Junio C Hamano 0 siblings, 1 reply; 6+ messages in thread From: Huynh Khoi Nguyen NGUYEN @ 2012-05-30 21:19 UTC (permalink / raw) To: git Cc: Matthieu.Moy, NGUYEN Huynh Khoi Nguyen, Huynh Khoi Nguyen NGUYEN, Lucien KONG, Valentin DUPERRAY, Thomas NGUY, Franck JONAS From: NGUYEN Huynh Khoi Nguyen <nguyenhu@ensibm.imag.fr> Git will read both in $XDG_CONFIG_HOME/git/config and in ~/.gitconfig in this order: .git/config > ~/.gitconfig > $XDG_CONFIG_HOME/git/config > /etc/gitconfig If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/config will be used. Signed-off-by: Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> Signed-off-by: Lucien KONG <Lucien.Kong@ensimag.imag.fr> Signed-off-by: Valentin DUPERRAY <Valentin.Duperray@ensimag.imag.fr> Signed-off-by: Thomas NGUY <Thomas.Nguy@ensimag.imag.fr> Signed-off-by: Franck JONAS <Franck.Jonas@ensimag.imag.fr> --- Documentation/git-config.txt | 9 +++- builtin/config.c | 48 +++++++++++++++++---- config.c | 21 ++++++++-- t/t1306-read-xdg-config-file.sh | 87 +++++++++++++++++++++++++++++++++++++++ 4 files changed, 149 insertions(+), 16 deletions(-) create mode 100755 t/t1306-read-xdg-config-file.sh diff --git a/Documentation/git-config.txt b/Documentation/git-config.txt index d9463cb..30418fa 100644 --- a/Documentation/git-config.txt +++ b/Documentation/git-config.txt @@ -99,8 +99,8 @@ OPTIONS For writing options: write to global ~/.gitconfig file rather than the repository .git/config. + -For reading options: read only from global ~/.gitconfig rather than -from all available files. +For reading options: read only from global ~/.gitconfig then from +$XDG_CONFIG_HOME/git/config rather than from all available files. + See also <<FILES>>. @@ -194,7 +194,7 @@ See also <<FILES>>. FILES ----- -If not set explicitly with '--file', there are three files where +If not set explicitly with '--file', there are four files where 'git config' will search for configuration options: $GIT_DIR/config:: @@ -204,6 +204,9 @@ $GIT_DIR/config:: User-specific configuration file. Also called "global" configuration file. +$XDG_CONFIG_HOME/git/config:: + Second user-specific configuration file. ~/.gitconfig has priority. + $(prefix)/etc/gitconfig:: System-wide configuration file. diff --git a/builtin/config.c b/builtin/config.c index 33c8820..38dba4f 100644 --- a/builtin/config.c +++ b/builtin/config.c @@ -161,7 +161,7 @@ static int show_config(const char *key_, const char *value_, void *cb) static int get_value(const char *key_, const char *regex_) { int ret = -1; - char *global = NULL, *repo_config = NULL; + char *gitconfig_global = NULL, *xdg_global = NULL, *repo_config = NULL; const char *system_wide = NULL, *local; struct config_include_data inc = CONFIG_INCLUDE_INIT; config_fn_t fn; @@ -171,8 +171,15 @@ static int get_value(const char *key_, const char *regex_) if (!local) { const char *home = getenv("HOME"); local = repo_config = git_pathdup("config"); - if (home) - global = xstrdup(mkpath("%s/.gitconfig", home)); + if (home) { + const char *xdg_config_home = getenv("XDG_CONFIG_HOME"); + if (xdg_config_home) + xdg_global = xstrdup(mkpath("%s/git/config", xdg_config_home)); + else + xdg_global = xstrdup(mkpath("%s/.config/git/config", home)); + + gitconfig_global = xstrdup(mkpath("%s/.gitconfig", home)); + } if (git_config_system()) system_wide = git_etc_gitconfig(); } @@ -229,15 +236,19 @@ static int get_value(const char *key_, const char *regex_) if (do_all && system_wide) git_config_from_file(fn, system_wide, data); - if (do_all && global) - git_config_from_file(fn, global, data); + if (do_all && xdg_global) + git_config_from_file(fn, xdg_global, data); + if (do_all && gitconfig_global) + git_config_from_file(fn, gitconfig_global, data); if (do_all) git_config_from_file(fn, local, data); git_config_from_parameters(fn, data); if (!do_all && !seen) git_config_from_file(fn, local, data); - if (!do_all && !seen && global) - git_config_from_file(fn, global, data); + if (!do_all && !seen && gitconfig_global) + git_config_from_file(fn, gitconfig_global, data); + if (!do_all && !seen && xdg_global) + git_config_from_file(fn, xdg_global, data); if (!do_all && !seen && system_wide) git_config_from_file(fn, system_wide, data); @@ -254,7 +265,8 @@ static int get_value(const char *key_, const char *regex_) free_strings: free(repo_config); - free(global); + free(gitconfig_global); + free(xdg_global); return ret; } @@ -381,7 +393,25 @@ int cmd_config(int argc, const char **argv, const char *prefix) if (use_global_config) { char *home = getenv("HOME"); if (home) { - char *user_config = xstrdup(mkpath("%s/.gitconfig", home)); + char *user_config; + const char *gitconfig_path = mkpath("%s/.gitconfig", home); + const char *xdg_config_path = NULL; + const char *xdg_config_home = NULL; + + xdg_config_home = getenv("XDG_CONFIG_HOME"); + if (xdg_config_home) + xdg_config_path = mkpath("%s/git/config", xdg_config_home); + else + xdg_config_path = mkpath("%s/.config/git/config", home); + + if (access(gitconfig_path, R_OK) && !access(xdg_config_path, R_OK) && + (actions == ACTION_LIST || + actions == ACTION_GET_COLOR || + actions == ACTION_GET_COLORBOOL)) + user_config = xstrdup(xdg_config_path); + else + user_config = xstrdup(gitconfig_path); + given_config_file = user_config; } else { die("$HOME not set"); diff --git a/config.c b/config.c index 71ef171..53557dc 100644 --- a/config.c +++ b/config.c @@ -939,10 +939,23 @@ int git_config_early(config_fn_t fn, void *data, const char *repo_config) home = getenv("HOME"); if (home) { - char buf[PATH_MAX]; - char *user_config = mksnpath(buf, sizeof(buf), "%s/.gitconfig", home); - if (!access(user_config, R_OK)) { - ret += git_config_from_file(fn, user_config, data); + const char *gitconfig_path = xstrdup(mkpath("%s/.gitconfig", home)); + const char *xdg_config_path = NULL; + const char *xdg_config_home = NULL; + + xdg_config_home = getenv("XDG_CONFIG_HOME"); + if (xdg_config_home) + xdg_config_path = xstrdup(mkpath("%s/git/config", xdg_config_home)); + else + xdg_config_path = xstrdup(mkpath("%s/.config/git/config", home)); + + if (!access(xdg_config_path, R_OK)) { + ret += git_config_from_file(fn, xdg_config_path, data); + found += 1; + } + + if (!access(gitconfig_path, R_OK)) { + ret += git_config_from_file(fn, gitconfig_path, data); found += 1; } } diff --git a/t/t1306-read-xdg-config-file.sh b/t/t1306-read-xdg-config-file.sh new file mode 100755 index 0000000..4cab38b --- /dev/null +++ b/t/t1306-read-xdg-config-file.sh @@ -0,0 +1,87 @@ +#!/bin/sh +# +# Copyright (c) 2012 Valentin Duperray, Lucien Kong, Franck Jonas, +# Thomas Nguy, Khoi Nguyen +# Grenoble INP Ensimag +# + +test_description='possibility to read $XDG_CONFIG_HOME/git/config file' + +. ./test-lib.sh + +test_expect_success 'read automatically: xdg file exists and ~/.gitconfig doesn'\''t' ' + mkdir -p .config/git && + echo "[advice]" >.config/git/config && + echo " statushints = false" >>.config/git/config && + cat >expect <<-\EOF && + # On branch master + # + # Initial commit + # + # Untracked files: + # .config/ + # expect + # output + nothing added to commit but untracked files present + EOF + git status >output && + test_cmp expect output +' + +test_expect_success 'read automatically: xdg file exists and ~/.gitconfig exists' ' + >.gitconfig && + echo "[advice]" >.gitconfig && + echo " statushints = true" >>.gitconfig && + cat >expect <<-\EOF && + # On branch master + # + # Initial commit + # + # Untracked files: + # (use "git add <file>..." to include in what will be committed) + # + # .config/ + # .gitconfig + # expect + # output + nothing added to commit but untracked files present (use "git add" to track) + EOF + git status >output && + test_cmp expect output +' + +test_expect_success 'read with --get: xdg file exists and ~/.gitconfig doesn'\''t' ' + rm .gitconfig && + echo "[user]" >.config/git/config && + echo " name = read_config" >>.config/git/config && + echo read_config >expect && + git config --get user.name >output && + test_cmp expect output +' + +test_expect_success 'read with --get: xdg file exists and ~/.gitconfig exists' ' + >.gitconfig && + echo "[user]" >.gitconfig && + echo " name = read_gitconfig" >>.gitconfig && + echo read_gitconfig >expect && + git config --get user.name >output && + test_cmp expect output +' + +test_expect_success 'read with --list: xdg file exists and ~/.gitconfig doesn'\''t' ' + rm .gitconfig && + echo user.name=read_config >expect && + git config --global --list >output && + test_cmp expect output +' + +test_expect_success 'read with --list: xdg file exists and ~/.gitconfig exists' ' + >.gitconfig && + echo "[user]" >.gitconfig && + echo " name = read_gitconfig" >>.gitconfig && + echo user.name=read_gitconfig >expect && + git config --global --list >output && + test_cmp expect output +' + +test_done -- 1.7.8 ^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config 2012-05-30 21:19 ` Huynh Khoi Nguyen NGUYEN @ 2012-05-30 21:54 ` Junio C Hamano 2012-05-31 22:06 ` Ramsay Jones 0 siblings, 1 reply; 6+ messages in thread From: Junio C Hamano @ 2012-05-30 21:54 UTC (permalink / raw) To: Huynh Khoi Nguyen NGUYEN Cc: git, Matthieu.Moy, NGUYEN Huynh Khoi Nguyen, Lucien KONG, Valentin DUPERRAY, Thomas NGUY, Franck JONAS Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> writes: > From: NGUYEN Huynh Khoi Nguyen <nguyenhu@ensibm.imag.fr> > > Git will read both in $XDG_CONFIG_HOME/git/config and in ~/.gitconfig in this order: > .git/config > ~/.gitconfig > $XDG_CONFIG_HOME/git/config > /etc/gitconfig > If $XDG_CONFIG_HOME is either not set or empty, $HOME/.config/git/config will be used. Is it just me who finds the above three lines extremely unreadable? Also can you give this patch a bit more sensible title? "Possibility to" does not tell us much---anything is possible if you change code after all. I see the patch does not touch the writing codepath, which is probably a good thing, but the log message should explicitly state that. > @@ -194,7 +194,7 @@ See also <<FILES>>. > FILES > ----- > > -If not set explicitly with '--file', there are three files where > +If not set explicitly with '--file', there are four files where > 'git config' will search for configuration options: > > $GIT_DIR/config:: > @@ -204,6 +204,9 @@ $GIT_DIR/config:: > User-specific configuration file. Also called "global" > configuration file. > > +$XDG_CONFIG_HOME/git/config:: > + Second user-specific configuration file. ~/.gitconfig has priority. > + I am not sure in what way $HOME/.gitconfig has "priority". Your proposed log message says that You read from $HOME/.gitconfig and then from $XDG_CONFIG_HOME/git/config, which means that any single-valued variable set in $HOME/.gitconfig will be overwritten by whatever is in $XDG_CONFIG_HOME/git/config, no? That sounds like you are giving priority to the latter to me. And for multi-valued variables, settings from both files are read, so there isn't much inherent priority between the two, except for variables for which the definition order matters, of course. If you read only from $HOME/.gitconfig if exists, and read from $XDG_CONFIG_HOME/git/config only when $HOME/.gitconfig does not, then you are giving $HOME/.gitconfig a priority, but that is not what the patch is doing as far as I can tell. > diff --git a/builtin/config.c b/builtin/config.c > index 33c8820..38dba4f 100644 > --- a/builtin/config.c > +++ b/builtin/config.c > @@ -161,7 +161,7 @@ static int show_config(const char *key_, const char *value_, void *cb) > static int get_value(const char *key_, const char *regex_) > { > int ret = -1; > - char *global = NULL, *repo_config = NULL; > + char *gitconfig_global = NULL, *xdg_global = NULL, *repo_config = NULL; > const char *system_wide = NULL, *local; > struct config_include_data inc = CONFIG_INCLUDE_INIT; > config_fn_t fn; > @@ -171,8 +171,15 @@ static int get_value(const char *key_, const char *regex_) > if (!local) { > const char *home = getenv("HOME"); > local = repo_config = git_pathdup("config"); > - if (home) > - global = xstrdup(mkpath("%s/.gitconfig", home)); > + if (home) { > + const char *xdg_config_home = getenv("XDG_CONFIG_HOME"); > + if (xdg_config_home) This is logically wrong; even when you fail to read $HOME, you may be able to read $XDG_CONFIG_HOME, no? It shouldn't be nested inside "if (home)" at all, methinks. It would be more like global = xdg_global = NULL; if (HOME exists?) global = $HOME/.gitconfig if (XDG_CONFIG_HOME exists?) xdg_global = $XDG_CONFIG_HOME/git/config else if (HOME exists?) xdg_global = $HOME/.config/git/config no? > @@ -381,7 +393,25 @@ int cmd_config(int argc, const char **argv, const char *prefix) > if (use_global_config) { > char *home = getenv("HOME"); > if (home) { > - char *user_config = xstrdup(mkpath("%s/.gitconfig", home)); > + char *user_config; > + const char *gitconfig_path = mkpath("%s/.gitconfig", home); > + const char *xdg_config_path = NULL; > + const char *xdg_config_home = NULL; > + > + xdg_config_home = getenv("XDG_CONFIG_HOME"); > + if (xdg_config_home) > + xdg_config_path = mkpath("%s/git/config", xdg_config_home); > + else > + xdg_config_path = mkpath("%s/.config/git/config", home); > + > + if (access(gitconfig_path, R_OK) && !access(xdg_config_path, R_OK) && > + (actions == ACTION_LIST || > + actions == ACTION_GET_COLOR || > + actions == ACTION_GET_COLORBOOL)) > + user_config = xstrdup(xdg_config_path); > + else > + user_config = xstrdup(gitconfig_path); > + > given_config_file = user_config; > } else { > die("$HOME not set"); Exactly the same comment applies here. You seem to always write to $HOME/.gitconfig, so missing $HOME may be an error if the action is to store, but if you are reading and if $XDG_CONFIG_HOME is set, you do not have to have $HOME set, no? Even when there is $HOME, if there is no $HOME/.gitconfig file, you wouldn't want to give an error, so missing $HOME environment should be treated pretty much the same way as missing $HOME/.gitconfig file for the purpose of reading, no? > diff --git a/config.c b/config.c > index 71ef171..53557dc 100644 > --- a/config.c > +++ b/config.c > @@ -939,10 +939,23 @@ int git_config_early(config_fn_t fn, void *data, const char *repo_config) > > home = getenv("HOME"); > if (home) { > - char buf[PATH_MAX]; > - char *user_config = mksnpath(buf, sizeof(buf), "%s/.gitconfig", home); > - if (!access(user_config, R_OK)) { > - ret += git_config_from_file(fn, user_config, data); > + const char *gitconfig_path = xstrdup(mkpath("%s/.gitconfig", home)); > + const char *xdg_config_path = NULL; > + const char *xdg_config_home = NULL; > + > + xdg_config_home = getenv("XDG_CONFIG_HOME"); > + if (xdg_config_home) > + xdg_config_path = xstrdup(mkpath("%s/git/config", xdg_config_home)); > + else > + xdg_config_path = xstrdup(mkpath("%s/.config/git/config", home)); Exactly the same comment applies here, too. The original that read from $HOME/.gitconfig was simple enough so having three copies of getenv("HOME") was perfectly fine, but as you are introduce this much complexity to to decide which two files to read from, the code added this patch needs to be refactored and three copies of the same logic need to be consolidated, I would have to say. ^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config 2012-05-30 21:54 ` Junio C Hamano @ 2012-05-31 22:06 ` Ramsay Jones 0 siblings, 0 replies; 6+ messages in thread From: Ramsay Jones @ 2012-05-31 22:06 UTC (permalink / raw) To: Junio C Hamano; +Cc: git Junio C Hamano wrote: > Huynh Khoi Nguyen NGUYEN <Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr> [...] >> diff --git a/config.c b/config.c >> index 71ef171..53557dc 100644 >> --- a/config.c >> +++ b/config.c >> @@ -939,10 +939,23 @@ int git_config_early(config_fn_t fn, void *data, const char *repo_config) >> >> home = getenv("HOME"); >> if (home) { >> - char buf[PATH_MAX]; >> - char *user_config = mksnpath(buf, sizeof(buf), "%s/.gitconfig", home); >> - if (!access(user_config, R_OK)) { >> - ret += git_config_from_file(fn, user_config, data); >> + const char *gitconfig_path = xstrdup(mkpath("%s/.gitconfig", home)); >> + const char *xdg_config_path = NULL; >> + const char *xdg_config_home = NULL; >> + >> + xdg_config_home = getenv("XDG_CONFIG_HOME"); >> + if (xdg_config_home) >> + xdg_config_path = xstrdup(mkpath("%s/git/config", xdg_config_home)); >> + else >> + xdg_config_path = xstrdup(mkpath("%s/.config/git/config", home)); > > Exactly the same comment applies here, too. I have not tried this patch (or the v3 version, which I haven't read yet), but is it likely that this has re-introduced the bug addressed by commit 05bab3ea ("config.c: Fix a static buffer overwrite bug by avoiding mkpath()", 19-11-2011)?. I don't know the answer, but I suspect that it may have done just that. (indeed, it may well have made the bug more likely to appear). > > The original that read from $HOME/.gitconfig was simple enough so > having three copies of getenv("HOME") was perfectly fine, but as you > are introduce this much complexity to to decide which two files to > read from, the code added this patch needs to be refactored and > three copies of the same logic need to be consolidated, I would have > to say. I agree. Also, using mksnpath() in the refactored code (rather than mkpath()) would be a good idea. :-P ATB, Ramsay Jones ^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2012-06-04 17:56 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2012-06-01 19:49 [PATCHv2] Possibility to read both from ~/.gitconfig and from $XDG_CONFIG_HOME/git/config nguyenhu
2012-06-04 17:27 ` Ramsay Jones
-- strict thread matches above, loose matches on Subject: below --
2012-05-31 8:46 nguyenhu
[not found] <1338400509-26087-1-git-send-email-Huynh-Khoi-Nguyen.Nguyen@ensimag.imag.fr>
2012-05-30 21:19 ` Huynh Khoi Nguyen NGUYEN
2012-05-30 21:54 ` Junio C Hamano
2012-05-31 22:06 ` Ramsay Jones
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).