From: Marc Branchaud <marcnarc@xiplink.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: Git Mailing List <git@vger.kernel.org>
Subject: Re: Help: Found odd git bug
Date: Mon, 04 Jun 2012 15:52:07 -0400 [thread overview]
Message-ID: <4FCD11E7.2060509@xiplink.com> (raw)
In-Reply-To: <7vd35ft159.fsf@alter.siamese.dyndns.org>
On 12-06-04 01:52 PM, Junio C Hamano wrote:
> Marc Branchaud <marcnarc@xiplink.com> writes:
>
>> A commit claims to add a line to a file. Indeed, "git diff" shows the line
>> being added.
>>
>> However, when I check out the commit, the file contains a *different* line,
>> with slightly modified contents.
>>
>> What's more, "git show SHA:path/to/file" shows that the blob contains the
>> wrong line.
>>
>> I found this using git 1.7.9, but 1.7.11.rc1 also shows the problem.
>>
>> How can I narrow down what's causing this problem?
>
> Without any information useful to diagnose, I would say it probably
> is not a bug but is an operator error when either of the "git diff"
> or "check out the commit" steps were done. Even if you cannot share
> the repository, at least a _complete_ command line with arguments is
> needed.
(Apply egg to face...)
Indeed, not a bug, nor a misunderstanding of git's workings. Rather, the
offending file already had a line that the no-longer-problematic commit
should have replaced, instead of adding a nearly-identical new line later on
in the file. So all this basically stems from not paying enough attention to
the diff's context surrounding the change.
Sorry for the false alarm, and thanks for the patient reply!
M.
prev parent reply other threads:[~2012-06-04 19:51 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-04 16:37 Help: Found odd git bug Marc Branchaud
2012-06-04 17:52 ` Junio C Hamano
2012-06-04 19:52 ` Marc Branchaud [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FCD11E7.2060509@xiplink.com \
--to=marcnarc@xiplink.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).