From: Vincent van Ravesteijn <vfr@lyx.org>
To: Junio C Hamano <gitster@pobox.com>
Cc: kusmabite@gmail.com, git@vger.kernel.org, Jeff King <peff@peff.net>
Subject: Re: [PATCH] t: Replace 'perl' by $PERL_PATH
Date: Tue, 12 Jun 2012 21:29:28 +0200 [thread overview]
Message-ID: <4FD79898.2050104@lyx.org> (raw)
In-Reply-To: <7vhaugjx9h.fsf@alter.siamese.dyndns.org>
Op 12-6-2012 18:44, Junio C Hamano schreef:
> Fair enough. After all, that is why we have $PERL_PATH that can be
> used (and is used) in our Porcelain scripts.
>
>
> As to vfr's patch, I'll replace $PERL_PATH with "$PERL_PATH" and queue.
Thanks. At least I'm now certain that all scripts use the same perl
interpreter.
The next question is whether the tests should also work with "the
broken" perl interpreter, i.e. the one that replaces LF with CRLF. I
also sent a patch on this issue for a single case, but there might be
more issues, or not. I'll report back when I know more.
Vincent
next prev parent reply other threads:[~2012-06-12 19:29 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 19:01 [PATCH] t: Replace 'perl' by $PERL_PATH vfr
2012-06-11 19:15 ` Junio C Hamano
2012-06-12 12:34 ` Jeff King
2012-06-12 14:56 ` Junio C Hamano
2012-06-12 14:59 ` Jeff King
2012-06-12 15:36 ` Erik Faye-Lund
2012-06-12 16:08 ` Junio C Hamano
2012-06-12 16:44 ` Junio C Hamano
2012-06-12 17:05 ` Jeff King
2012-06-12 19:29 ` Vincent van Ravesteijn [this message]
2012-06-17 6:36 ` Torsten Bögershausen
2012-06-17 7:15 ` Junio C Hamano
2012-06-17 8:50 ` Torsten Bögershausen
2012-06-17 22:23 ` Junio C Hamano
2012-06-20 20:16 ` Torsten Bögershausen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD79898.2050104@lyx.org \
--to=vfr@lyx.org \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=kusmabite@gmail.com \
--cc=peff@peff.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).