From: "Simon.Cathebras" <Simon.Cathebras@ensimag.imag.fr>
To: Matthieu Moy <Matthieu.Moy@grenoble-inp.fr>
Cc: git@vger.kernel.org, gitster@pobox.com, peff@peff.net,
Guillaume Sasdy <guillaume.sasdy@ensimag.imag.fr>,
Simon Perrat <simon.perrat@ensimag.imag.fr>,
Charles Roussel <charles.roussel@ensimag.imag.fr>,
Julien Khayat <julien.khayat@ensimag.imag.fr>
Subject: Re: [PATCH 2/6] Test environment of git-remote-mediawiki
Date: Wed, 13 Jun 2012 10:10:31 +0200 [thread overview]
Message-ID: <4FD84AF7.20105@ensimag.imag.fr> (raw)
In-Reply-To: <vpqtxyfk5l8.fsf@bauges.imag.fr>
On 13/06/2012 09:56, Matthieu Moy wrote:
> Simon Cathebras<simon.cathebras@ensimag.imag.fr> writes:
>
>> +# Check the preconditions to run git-remote-mediawiki's tests
>> +test_check_precond () {
> This is a very generic name (with risk of name clash in future versions
> of test-lib.sh). This checks the git-mediawiki preconditions, so how
> about test_check_wiki_precond?
I agree with that.
>> + if ! test_have_prereq PERL
>> + then
>> + skip_all='skipping gateway git-mw tests, perl not available'
>> + test_done
>> + fi
>> +
>> + if [ ! -f $GIT_BUILD_DIR/git-remote-mediawiki ];
> "" around $GIT_BUILD_DIR
>
> But why $GIT_BUILD_DIR ? git-remote-mediawiki usually doesn't go there,
> it is either as source in contrib/, or installed in the $PATH.
Indeed, I developped this code and I have missunderstood the behavior of
contrib. It will be fix in the next patch by tonight.
>> + then
>> + skip_all='skipping gateway git-mw tests, no remote mediawiki for git found' \
>> + 'please try: cp git/contrib/mw-to-git/git-remote-mediawiki git/'
> Don't you have a "make install" target for that now?
Yes we have. We shall correct it by tonight.
>
> + $CURR_DIR/test-gitmw.pl getallpagename
>
> Here and elsewhere, "" around "$CURR_DIR"
>
Got it, thanks =).
Simon C
--
CATHEBRAS Simon
2A-ENSIMAG
Filière Ingéniérie des Systèmes d'Information
Membre Bug-Buster
next prev parent reply other threads:[~2012-06-13 8:10 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-11 20:27 [PATCH]Test environment for git-remote-mediawiki Simon.Cathebras
2012-06-11 20:28 ` [PATCHv3 1/6] Scripts to install, delete and clear a MediaWiki Simon Cathebras
2012-06-11 20:28 ` [PATCHv3 2/6] Test environment of git-remote-mediawiki Simon Cathebras
2012-06-11 20:28 ` [PATCHv3 3/6] Test file for git-remote-mediawiki clone Simon Cathebras
2012-06-11 21:07 ` konglu
2012-06-12 13:58 ` Simon.Cathebras
2012-06-11 20:28 ` [PATCHv3 4/6] Tests for git-remote-mediawiki pull Simon Cathebras
2012-06-11 21:09 ` konglu
2012-06-12 13:58 ` Simon Perrat
2012-06-12 21:12 ` [PATCH 1/6] Scripts to install, delete and clear a MediaWiki Simon Cathebras
2012-06-12 21:12 ` [PATCH 2/6] Test environment of git-remote-mediawiki Simon Cathebras
2012-06-13 7:56 ` Matthieu Moy
2012-06-13 8:10 ` Simon.Cathebras [this message]
2012-06-13 10:14 ` Ævar Arnfjörð Bjarmason
2012-06-13 17:00 ` Simon.Cathebras
2012-06-13 17:03 ` [PATCHv5 1/5] Scripts to install, delete and clear a MediaWiki Simon Cathebras
2012-06-13 17:03 ` [PATCHv5 2/5] Test environment of git-remote-mediawiki Simon Cathebras
2012-06-13 17:03 ` [PATCHv5 3/5] Test file for git-remote-mediawiki clone Simon Cathebras
2012-06-13 17:03 ` [PATCHv5 4/5] Tests for git-remote-mediawiki pull and push Simon Cathebras
2012-06-13 17:03 ` [PATCHv5 5/5] Tests of UTF8 character with git-remote-mediawiki Simon Cathebras
2012-06-14 8:57 ` [PATCHv5 1/5] Scripts to install, delete and clear a MediaWiki Matthieu Moy
2012-06-14 8:57 ` [PATCH 1/3] chmod -x test-gitmw-lib.sh Matthieu Moy
2012-06-14 8:57 ` [PATCH 2/3] Coding style Matthieu Moy
2012-06-14 8:57 ` [PATCH 3/3] Explicit error when curl_exec() fails Matthieu Moy
2012-06-14 9:23 ` Simon.Cathebras
2012-06-14 12:45 ` Matthieu Moy
2012-06-14 9:20 ` [PATCHv5 1/5] Scripts to install, delete and clear a MediaWiki Simon.Cathebras
2012-06-14 16:17 ` Matthieu Moy
2012-06-14 8:58 ` Matthieu Moy
2012-06-12 21:12 ` [PATCH 3/6] Test file for git-remote-mediawiki clone Simon Cathebras
2012-06-12 21:34 ` konglu
2012-06-13 7:20 ` Simon.Cathebras
2012-06-12 21:12 ` [PATCH 4/6] Tests for git-remote-mediawiki pull and push Simon Cathebras
2012-06-12 21:12 ` [PATCH 5/6] Tests of UTF8 character with git-remote-mediawiki Simon Cathebras
2012-06-12 21:18 ` Simon.Cathebras
2012-06-12 21:52 ` konglu
2012-06-13 7:30 ` Simon.Cathebras
2012-06-12 21:45 ` konglu
2012-06-11 20:28 ` [PATCHv3 5/6] Test file for git-remote-mediawiki push Simon Cathebras
2012-06-11 20:28 ` =?y?q?=5BPATCHv3=206/6=5D=20Tests=20of=20UTF8=20character=20with=20git-remote-mediawiki?= Simon Cathebras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FD84AF7.20105@ensimag.imag.fr \
--to=simon.cathebras@ensimag.imag.fr \
--cc=Matthieu.Moy@grenoble-inp.fr \
--cc=charles.roussel@ensimag.imag.fr \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=guillaume.sasdy@ensimag.imag.fr \
--cc=julien.khayat@ensimag.imag.fr \
--cc=peff@peff.net \
--cc=simon.perrat@ensimag.imag.fr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).