From: Brad King <brad.king@kitware.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org
Subject: Re: [PATCH 0/2] submodule add + autocrlf + safecrlf
Date: Wed, 20 Jun 2012 14:09:12 -0400 [thread overview]
Message-ID: <4FE211C8.3080007@kitware.com> (raw)
In-Reply-To: <7vipelx49g.fsf@alter.siamese.dyndns.org>
On 06/20/2012 01:49 PM, Junio C Hamano wrote:
> I have a suspicion that "git config" should be taught about this
> kind of thing instead.
>
> Shoudn't your .git/config file that is outside the revision control
> also end with CRLF if your platform and project prefer CRLF over LF?
That would be reasonable, but is beyond the scope I'm willing to
tackle myself.
I don't actually have a project like this so I have no strong
opinion on this issue. I discovered the problem by accident
and have already worked around it in the obscure case it matters
for me.
Perhaps only the first patch in the series is worth inclusion.
It can become the beginning of a series if someone wants to address
handling crlf in config files. Note that in the case I discovered
this the crlf configuration was in ~/.gitconfig so the project
knew nothing about it and had no .gitattributes.
-Brad
next prev parent reply other threads:[~2012-06-20 18:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-20 14:43 [PATCH 0/2] submodule add + autocrlf + safecrlf Brad King
2012-06-20 14:43 ` [PATCH 1/2] submodule: Demonstrate failure to add with auto/safecrlf Brad King
2012-06-20 14:43 ` [PATCH 2/2] submodule: Tolerate auto/safecrlf when adding .gitmodules Brad King
2012-06-20 17:52 ` Jens Lehmann
2012-06-20 18:06 ` Brad King
2012-06-20 18:21 ` Jens Lehmann
2012-06-20 19:11 ` Jeff King
2012-06-20 19:53 ` Junio C Hamano
2012-06-21 19:06 ` Jens Lehmann
2012-06-20 17:49 ` [PATCH 0/2] submodule add + autocrlf + safecrlf Junio C Hamano
2012-06-20 18:09 ` Brad King [this message]
2012-06-20 19:24 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE211C8.3080007@kitware.com \
--to=brad.king@kitware.com \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).