From: "Thomas \"Enki\" Badie" <thomas.badie@gmail.com>
To: git@vger.kernel.org
Subject: [PATCH] git-add--interactive.perl: Remove two unused variables
Date: Sun, 24 Jun 2012 23:37:34 +0200 [thread overview]
Message-ID: <4FE7889E.2020009@gmail.com> (raw)
The patch 8f0bef6 refactors this script and leaves the `$fh' variable
unused in `diff_applies' and `patch_update_file'.
Signed-off-by: Thomas Badie <badie@lrde.epita.fr>
---
Hello,
This is my first patch. It introduces a really minor change, and I
also want to be sure the way I submit it is the right way. Thanks :)
git-add--interactive.perl | 2 --
1 files changed, 0 insertions(+), 2 deletions(-)
diff --git a/git-add--interactive.perl b/git-add--interactive.perl
index d948aa8..710764a 100755
--- a/git-add--interactive.perl
+++ b/git-add--interactive.perl
@@ -1067,7 +1067,6 @@ EOF
}
sub diff_applies {
- my $fh;
return run_git_apply($patch_mode_flavour{APPLY_CHECK} . '--check',
map { @{$_->{TEXT}} } @_);
}
@@ -1514,7 +1513,6 @@ sub patch_update_file {
}
if (@result) {
- my $fh;
my @patch = reassemble_patch($head->{TEXT}, @result);
my $apply_routine = $patch_mode_flavour{APPLY};
&$apply_routine(@patch);
--
1.7.5.4
next reply other threads:[~2012-06-24 21:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-06-24 21:37 Thomas "Enki" Badie [this message]
2012-06-25 5:41 ` [PATCH] git-add--interactive.perl: Remove two unused variables Junio C Hamano
2012-06-25 9:12 ` Thomas Rast
2012-06-25 10:16 ` Thomas Badie
2012-06-25 10:12 ` Thomas Badie
2012-06-25 18:06 ` Junio C Hamano
2012-06-25 22:41 ` Thomas Badie
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FE7889E.2020009@gmail.com \
--to=thomas.badie@gmail.com \
--cc=git@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).