From: Marc Branchaud <mbranchaud@xiplink.com>
To: Junio C Hamano <gitster@pobox.com>
Cc: git@vger.kernel.org, Jens.Lehmann@web.de, peff@peff.net,
phil.hord@gmail.com
Subject: Re: [PATCH 3/6] Teach clone to set remote.default.
Date: Fri, 06 Jul 2012 17:49:11 -0400 [thread overview]
Message-ID: <4FF75D57.7010603@xiplink.com> (raw)
In-Reply-To: <4FF74DD4.1060800@xiplink.com>
On 12-07-06 04:43 PM, Marc Branchaud wrote:
>
> So why change "git clone" to always set remote.default if the functionality
> remains the same either way?
>
> To me it makes a more consistent implementation. Since "git remote add" sets
> remote.default if it's adding the first remote to the repository, when clone
> itself adds the first remote it should do the same.
>
> Plus this approach makes "clone -o" also work without any special-casing, so
> the code is cleaner, IMHO.
Also, it means that
git clone /some/repo
and
git clone -o origin /some/repo
produce exactly the same result.
M.
next prev parent reply other threads:[~2012-07-06 21:56 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-07-05 22:11 [PATCH 0/6] Default remote marcnarc
2012-07-05 22:11 ` [PATCH 1/6] Rename remote.c's default_remote_name static variables marcnarc
2012-07-05 22:11 ` [PATCH 2/6] Teach remote.c about the remote.default configuration setting marcnarc
2012-07-05 22:50 ` Junio C Hamano
2012-07-06 14:36 ` Marc Branchaud
2012-07-06 19:31 ` Junio C Hamano
2012-07-06 19:57 ` Marc Branchaud
2012-07-05 22:11 ` [PATCH 3/6] Teach clone to set remote.default marcnarc
2012-07-05 22:52 ` Junio C Hamano
2012-07-06 14:37 ` Marc Branchaud
2012-07-06 19:39 ` Junio C Hamano
2012-07-06 20:43 ` Marc Branchaud
2012-07-06 21:49 ` Marc Branchaud [this message]
2012-07-05 22:11 ` [PATCH 4/6] Teach "git remote" about remote.default marcnarc
2012-07-06 12:51 ` Phil Hord
2012-07-06 14:43 ` Marc Branchaud
2012-07-05 22:11 ` [PATCH 5/6] Test that plain "git fetch" uses remote.default when on a detached HEAD marcnarc
2012-07-05 22:11 ` [PATCH 6/6] Teach get_default_remote to respect remote.default marcnarc
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4FF75D57.7010603@xiplink.com \
--to=mbranchaud@xiplink.com \
--cc=Jens.Lehmann@web.de \
--cc=git@vger.kernel.org \
--cc=gitster@pobox.com \
--cc=marcnarc@xiplink.com \
--cc=peff@peff.net \
--cc=phil.hord@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).