Git development
 help / color / mirror / Atom feed
From: Richard Lloyd <richard.lloyd@connectinternetsolutions.com>
To: Jeff King <peff@peff.net>
Cc: git@vger.kernel.org
Subject: Re: Systems with old regex system headers/libraries don't pick up git's compat/regex header file
Date: Fri, 7 Oct 2016 16:45:08 +0100	[thread overview]
Message-ID: <4ac0ce84-ca6c-3650-ef5e-e13c54c60504@connectinternetsolutions.com> (raw)
In-Reply-To: <20161006191127.2vjtmxl7ygjeqcbk@sigill.intra.peff.net>

On 06/10/16 20:11, Jeff King wrote:
> Junio mentioned the NO_REGEX knob in the Makefile. If that works for
> you, the next step is probably to add a line to the HP-UX section of
> config.mak.uname, so that it just works out of the box.

This doesn't work because the check in git-compat-util.h only looks
for REG_STARTEND being defined (if it isn't, it #error's out).

That define is not mentioned anywhere else other than in the
compat/regex tree, which is why I used -Icompat/regex to pick up
<regex.h> from there - this was the "easiest" solution for me on
HP-UX 11.

Note that with this inclusion change, the source compiled and linked
fine on HP-UX 11 and git passed its tests, including the regex-based ones.

Richard K. Lloyd,           E-mail: richard.lloyd@connectinternetsolutions.com
Connect Internet Solutions,    WWW: https://www.connectinternetsolutions.com/
4th Floor, New Barratt House,
47, North John Street,
Liverpool,
Merseyside, UK. L2 6SG




>
> -Peff
>




-- 
This e-mail (and any attachments) is private and confidential. If you have 
received it in error, please notify the sender immediately and delete it 
from your system. Do not use, copy or disclose the information in any way 
nor act in reliance on it.

Any views expressed in this message are those of the individual sender,
except where the sender specifically states them to be the views of Connect
Internet Solutions Ltd. This e-mail and any attachments are believed to be
virus free but it is the recipient's responsibility to ensure that they are.

Connect Internet Solutions Ltd
(A company registered in England No: 04424350)
Registered Office: 4th Floor, New Barratt House, 47 North John Street,
Liverpool, L2 6SG
Telephone: +44 (0) 151 282 4321
VAT registration number: 758 2838 85

  reply	other threads:[~2016-10-07 15:45 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-10-06  9:15 Systems with old regex system headers/libraries don't pick up git's compat/regex header file Richard Lloyd
2016-10-06 18:25 ` Junio C Hamano
2016-10-06 19:11 ` Jeff King
2016-10-07 15:45   ` Richard Lloyd [this message]
2016-10-07 16:06     ` Jeff King

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ac0ce84-ca6c-3650-ef5e-e13c54c60504@connectinternetsolutions.com \
    --to=richard.lloyd@connectinternetsolutions.com \
    --cc=git@vger.kernel.org \
    --cc=peff@peff.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox