git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Tuncer Ayaz" <tuncer.ayaz@gmail.com>
To: git@vger.kernel.org
Cc: barkalow@iabervon.org, davej@codemonkey.org.uk
Subject: [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied.
Date: Fri, 3 Oct 2008 21:34:33 +0200	[thread overview]
Message-ID: <4ac8254d0810031234x26ebc96cy7cf5dcae2ef516e0@mail.gmail.com> (raw)

Following is a patch to complete the changes discussed
here http://marc.info/?l=git&m=121529226023180&w=2.

I hope it makes sense and doesn't break something else.

With this simple one-liner patch applied I no longer see
the following remote messages as no-progress is correctly
sent to the remote site:
remote: Counting objects: 84102, done.
remote: Compressing objects: 100% (24720/24720), done.
remote: Total 84102 (delta 60949), reused 80810 (delta 57900)

Regards,

        Tuncer Ayaz

Signed-off-by: Tuncer Ayaz <tuncer.ayaz@gmail.com>
---
 transport.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/transport.c b/transport.c
index 71433d9..1f24011 100644
--- a/transport.c
+++ b/transport.c
@@ -644,7 +644,7 @@ static int fetch_refs_via_pack(struct transport *transport,
    args.include_tag = data->followtags;
    args.verbose = (transport->verbose > 0);
    args.quiet = args.no_progress = (transport->verbose < 0);
-   args.no_progress = !isatty(1);
+   args.no_progress = args.quiet || !isatty(1);
    args.depth = data->depth;

    for (i = 0; i < nr_heads; i++)
-- 
1.6.0.2

             reply	other threads:[~2008-10-03 19:35 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2008-10-03 19:34 Tuncer Ayaz [this message]
2008-10-03 19:50 ` [PATCH] Fix argument handling for fetch-pack call when stdout is connected and -q/--quiet is supplied Daniel Barkalow
2008-10-03 20:18   ` Tuncer Ayaz
2008-10-03 20:33     ` Constantine Plotnikov
2008-10-03 20:39       ` Daniel Barkalow
2008-10-03 20:44       ` Tuncer Ayaz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ac8254d0810031234x26ebc96cy7cf5dcae2ef516e0@mail.gmail.com \
    --to=tuncer.ayaz@gmail.com \
    --cc=barkalow@iabervon.org \
    --cc=davej@codemonkey.org.uk \
    --cc=git@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).