git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Derrick Stolee <stolee@gmail.com>
To: Teng Long <dyroneteng@gmail.com>, git@vger.kernel.org
Cc: gitster@pobox.com, me@ttaylorr.com
Subject: Re: [PATCH] midx: fix a formatting issue in "multi-pack-index.txt"
Date: Mon, 15 Nov 2021 11:25:56 -0500	[thread overview]
Message-ID: <4ad06bc6-4f11-d6ef-ec95-ab0e9db9c2c7@gmail.com> (raw)
In-Reply-To: <20211115063318.14426-1-dyroneteng@gmail.com>

On 11/15/2021 1:33 AM, Teng Long wrote:
> Signed-off-by: Teng Long <dyroneteng@gmail.com>

Hi Teng,

Could you spend some time in your commit message explaining what
is wrong about the characters used for bullet points here?

> -  - A value j referring to the jth packfile.
> -  - An offset within the jth packfile for the object.
> +  * A value j referring to the jth packfile.
> +  * An offset within the jth packfile for the object.
>  - If large offsets are required, we use another list of large
>    offsets similar to version 2 pack-indexes.

Is it that the indentation isn't enough to show a sublist? I see
that the HTML rendering on git-scm.com [1] does fail to show this
sublist, and I could believe that this change would fix it (but I
am not sure).

[1] https://www.git-scm.com/docs/multi-pack-index

Thanks,
-Stolee

  reply	other threads:[~2021-11-15 16:26 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-11-15  6:33 [PATCH] midx: fix a formatting issue in "multi-pack-index.txt" Teng Long
2021-11-15 16:25 ` Derrick Stolee [this message]
2021-11-16 21:49   ` Taylor Blau
2021-11-18  3:39     ` Teng Long
2021-11-18  7:11 ` [PATCH v2 0/1] [PATCH] midx: fix a formatting issue in docs Teng Long
2021-11-18  7:11   ` [PATCH v2 1/1] midx: fix a formatting issue in "multi-pack-index.txt" Teng Long
2021-11-18 12:16     ` Derrick Stolee
2021-11-18 23:51     ` Junio C Hamano

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4ad06bc6-4f11-d6ef-ec95-ab0e9db9c2c7@gmail.com \
    --to=stolee@gmail.com \
    --cc=dyroneteng@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=gitster@pobox.com \
    --cc=me@ttaylorr.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).