From: "Mansi Singh via GitGitGadget" <gitgitgadget@gmail.com>
To: git@vger.kernel.org
Cc: Mansi Singh <mansimaanu8627@gmail.com>,
Mansi Singh <mansimaanu8627@gmail.com>
Subject: [PATCH 2/2] repo: remove redundant variable shadow in stats_table_print_structure
Date: Tue, 10 Mar 2026 02:16:58 +0000 [thread overview]
Message-ID: <4adf6d4dca90e2c7f780d594a533c21247c459b8.1773109018.git.gitgitgadget@gmail.com> (raw)
In-Reply-To: <pull.2062.git.1773109018.gitgitgadget@gmail.com>
From: Mansi Singh <mansimaanu8627@gmail.com>
In stats_table_print_structure(), the variable 'entry' is declared
at the top of the loop body and assigned from item->util. Inside
the 'if (entry)' block, the same variable is redeclared and assigned
identically, shadowing the outer declaration unnecessarily.
Remove the inner redeclaration since the outer 'entry' is already
available and non-NULL at that point.
Signed-off-by: Mansi Singh <mansimaanu8627@gmail.com>
---
builtin/repo.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/builtin/repo.c b/builtin/repo.c
index 0ea045abc1..5540bd25d2 100644
--- a/builtin/repo.c
+++ b/builtin/repo.c
@@ -412,7 +412,6 @@ static void stats_table_print_structure(const struct stats_table *table)
const char *unit = "";
if (entry) {
- struct stats_table_entry *entry = item->util;
value = entry->value;
if (entry->unit)
unit = entry->unit;
--
gitgitgadget
next prev parent reply other threads:[~2026-03-10 2:17 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-03-10 2:16 [PATCH 0/2] repo: remove redundant variable shadow in stats_table_print_structure Mansi Singh via GitGitGadget
2026-03-10 2:16 ` [PATCH 1/2] t7605: use test_path_is_file instead of test -f Mansi via GitGitGadget
2026-03-10 2:16 ` Mansi Singh via GitGitGadget [this message]
2026-03-10 13:08 ` [PATCH 0/2] repo: remove redundant variable shadow in stats_table_print_structure K Jayatheerth
2026-03-10 3:08 ` Junio C Hamano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4adf6d4dca90e2c7f780d594a533c21247c459b8.1773109018.git.gitgitgadget@gmail.com \
--to=gitgitgadget@gmail.com \
--cc=git@vger.kernel.org \
--cc=mansimaanu8627@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox