From: "Kristoffer Haugsbakk" <kristofferhaugsbakk@fastmail.com>
To: "Eric Sunshine" <sunshine@sunshineco.com>
Cc: "Josh Soref" <gitgitgadget@gmail.com>,
git@vger.kernel.org, oneee <kimww0306@gmail.com>
Subject: Re: [PATCH] doc: sparse-checkout: Fix list markers
Date: Wed, 28 May 2025 10:01:17 +0200 [thread overview]
Message-ID: <4c1f645b-42fb-40b9-987e-08ce9e057e01@app.fastmail.com> (raw)
In-Reply-To: <CAPig+cTdN=x2GXGW2p_g_k4jgC0eQmjW5zLsWhJm-PP7eMBTiQ@mail.gmail.com>
On Wed, May 28, 2025, at 09:20, Eric Sunshine wrote:
>> Because then you can use commas freely inside each point.
>
> I'd like to push back on this suggestion, at least in the context of
> this particular patch, the purpose of which is to fix an actual
> problem in the documentation. The sort of improvement you suggest
> probably ought to be done as a separate patch, but let's not make it
> seem as if we are heaping extra work on the patch submitter; it's more
> important to get the fix itself landed.
>
> As such, the patch itself looks obviously correct and is a definite
> improvement as-is. It's not clear why it didn't get picked up; perhaps
> it just fell through the cracks.
Okay, totally reasonable and makes sense IMO.
next prev parent reply other threads:[~2025-05-28 8:01 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-21 12:41 [PATCH] doc: sparse-checkout: Fix list markers oneee via GitGitGadget
2025-05-28 6:56 ` Kristoffer Haugsbakk
2025-05-28 7:20 ` Eric Sunshine
2025-05-28 8:01 ` Kristoffer Haugsbakk [this message]
2025-05-30 3:43 ` oneee
2025-05-30 5:00 ` Eric Sunshine
2025-05-30 7:18 ` oneee
2025-05-30 13:38 ` Junio C Hamano
2025-05-28 7:14 ` Patrick Steinhardt
2025-05-30 7:22 ` [PATCH v2] doc: sparse-checkout: use consistent inline list style oneee via GitGitGadget
2025-05-30 7:41 ` Kristoffer Haugsbakk
-- strict thread matches above, loose matches on Subject: below --
2025-05-28 6:19 [PATCH] doc: sparse-checkout: Fix list markers oneee
2025-05-28 6:36 ` Kristoffer Haugsbakk
2025-05-28 7:14 ` Patrick Steinhardt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4c1f645b-42fb-40b9-987e-08ce9e057e01@app.fastmail.com \
--to=kristofferhaugsbakk@fastmail.com \
--cc=git@vger.kernel.org \
--cc=gitgitgadget@gmail.com \
--cc=kimww0306@gmail.com \
--cc=sunshine@sunshineco.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).