git.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Fredrik Kuivinen" <frekui@gmail.com>
To: "Junio C Hamano" <junkio@cox.net>
Cc: git@vger.kernel.org
Subject: Re: [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to
Date: Sun, 7 Jan 2007 13:56:59 +0100	[thread overview]
Message-ID: <4c8ef70701070456k2f0585f4ga6c35bd77c939c59@mail.gmail.com> (raw)
In-Reply-To: <7v8xgg553u.fsf@assigned-by-dhcp.cox.net>

On 1/6/07, Junio C Hamano <junkio@cox.net> wrote:
> Fredrik Kuivinen <freku045@student.liu.se> writes:
>
> > Idea and motivating example from Andy Whitcroft:
> >
> >     apw@pinky$ git checkout -b bar master
> >     apw@pinky$ git reset --hard ac9c1108d8915f0937795e354ad72c4ae6890a3f
> >     HEAD is now at ac9c110... git-fetch: remove .keep file at the end.
> >
> >     Huh, fetch?  Remove what .keep file?  Did I do a fetch?  What?
> >
> >     I think we need to delimit the name better, probabally we need to quote
> >     it.  Perhaps something like:
> >
> >     HEAD is now at ac9c110: "git-fetch: remove .keep file at the end".
>
> I've also considered something along that line, but:
>
>  (1) I think this 'confusion' is only because you are futzing
>      with a project that deals with git-fetch and friends and
>      not a general problem.
>
>  (2) With "HEAD is now at xxxxx..."  prefix, even two characters
>      are precious to fit the title of the commit on a single
>      line.
>
> With these in mind, do you still want to do this?

I don't think the second point is much of an issue. Is it really that
irritating to
read a word-wrapped line of text? I agree with the first point though, in most
cases it will not be a problem in other projects.

I still think it is worth doing it, but it certainly isn't super
important. Feel free
to drop the patch if you want to.

- Fredrik

  reply	other threads:[~2007-01-07 12:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2007-01-06 10:23 [PATCH] git-reset --hard: use quotes when we tell the user what HEAD was reset to Fredrik Kuivinen
2007-01-06 19:26 ` Junio C Hamano
2007-01-07 12:56   ` Fredrik Kuivinen [this message]
2007-01-07 21:10     ` Junio C Hamano
2007-01-08  8:33       ` Andy Whitcroft

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4c8ef70701070456k2f0585f4ga6c35bd77c939c59@mail.gmail.com \
    --to=frekui@gmail.com \
    --cc=git@vger.kernel.org \
    --cc=junkio@cox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).